-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-reporting-services
#202741
Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-reporting-services
#202741
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
Pinging @elastic/kibana-core (Team:Core) |
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SCSS files only
0fcd5df
to
c9723a0
Compare
1464506
to
dc60dd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only manifest changes required for core review. File moved without changes.
LGTM
3825a65
to
f6e093e
Compare
/ci |
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]
History
|
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…na-reporting-services` (elastic#202741) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > This PR has been auto-generated. > Do not attempt to push any changes unless you know what you are doing. > Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. #### 1 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/screenshotting-plugin` | `x-pack/platform/plugins/shared/screenshotting` | <details> <summary>Updated references</summary> ``` ./docs/developer/plugin-list.asciidoc ./package.json ./packages/kbn-cli-dev-mode/src/watcher.ts ./packages/kbn-repo-packages/package-map.json ./packages/kbn-ts-projects/config-paths.json ./src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js ./src/dev/precommit_hook/casing_check_config.js ./tsconfig.base.json ./x-pack/.gitignore ./x-pack/.i18nrc.json ./x-pack/platform/plugins/shared/screenshotting/README.md ./x-pack/platform/plugins/shared/screenshotting/jest.config.js ./x-pack/platform/plugins/shared/screenshotting/jest.integration.config.js ./x-pack/platform/plugins/shared/screenshotting/server/screenshots/screenshots.test.ts ./x-pack/plugins/lens/public/app_plugin/share_action.ts ./yarn.lock ``` </details> <details> <summary>Updated relative paths</summary> ``` x-pack/platform/plugins/shared/screenshotting/jest.config.js:10 x-pack/platform/plugins/shared/screenshotting/jest.integration.config.js:10 x-pack/platform/plugins/shared/screenshotting/server/formats/pdf/pdf_maker/worker_src_harness.js:14 x-pack/platform/plugins/shared/screenshotting/tsconfig.json:10 x-pack/platform/plugins/shared/screenshotting/tsconfig.json:14 x-pack/platform/plugins/shared/screenshotting/tsconfig.json:2 ``` </details> <details> <summary>Script errors</summary> ``` ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0e2fc8f) # Conflicts: # .github/CODEOWNERS
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
…c/kibana-reporting-services` (#202741) (#204901) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-reporting-services` (#202741)](#202741) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-12-18T01:49:07Z","message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-reporting-services` (#202741)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 1 plugin(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/screenshotting-plugin` |\r\n`x-pack/platform/plugins/shared/screenshotting` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-cli-dev-mode/src/watcher.ts\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js\r\n./src/dev/precommit_hook/casing_check_config.js\r\n./tsconfig.base.json\r\n./x-pack/.gitignore\r\n./x-pack/.i18nrc.json\r\n./x-pack/platform/plugins/shared/screenshotting/README.md\r\n./x-pack/platform/plugins/shared/screenshotting/jest.config.js\r\n./x-pack/platform/plugins/shared/screenshotting/jest.integration.config.js\r\n./x-pack/platform/plugins/shared/screenshotting/server/screenshots/screenshots.test.ts\r\n./x-pack/plugins/lens/public/app_plugin/share_action.ts\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nx-pack/platform/plugins/shared/screenshotting/jest.config.js:10\r\nx-pack/platform/plugins/shared/screenshotting/jest.integration.config.js:10\r\nx-pack/platform/plugins/shared/screenshotting/server/formats/pdf/pdf_maker/worker_src_harness.js:14\r\nx-pack/platform/plugins/shared/screenshotting/tsconfig.json:10\r\nx-pack/platform/plugins/shared/screenshotting/tsconfig.json:14\r\nx-pack/platform/plugins/shared/screenshotting/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"0e2fc8f4e22a9dd41fc0b0f3c0ea2bd448a6c73e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor","Team:Reporting Services","plugin groups"],"number":202741,"url":"https://github.com/elastic/kibana/pull/202741","mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-reporting-services` (#202741)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 1 plugin(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/screenshotting-plugin` |\r\n`x-pack/platform/plugins/shared/screenshotting` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-cli-dev-mode/src/watcher.ts\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js\r\n./src/dev/precommit_hook/casing_check_config.js\r\n./tsconfig.base.json\r\n./x-pack/.gitignore\r\n./x-pack/.i18nrc.json\r\n./x-pack/platform/plugins/shared/screenshotting/README.md\r\n./x-pack/platform/plugins/shared/screenshotting/jest.config.js\r\n./x-pack/platform/plugins/shared/screenshotting/jest.integration.config.js\r\n./x-pack/platform/plugins/shared/screenshotting/server/screenshots/screenshots.test.ts\r\n./x-pack/plugins/lens/public/app_plugin/share_action.ts\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nx-pack/platform/plugins/shared/screenshotting/jest.config.js:10\r\nx-pack/platform/plugins/shared/screenshotting/jest.integration.config.js:10\r\nx-pack/platform/plugins/shared/screenshotting/server/formats/pdf/pdf_maker/worker_src_harness.js:14\r\nx-pack/platform/plugins/shared/screenshotting/tsconfig.json:10\r\nx-pack/platform/plugins/shared/screenshotting/tsconfig.json:14\r\nx-pack/platform/plugins/shared/screenshotting/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"0e2fc8f4e22a9dd41fc0b0f3c0ea2bd448a6c73e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202741","number":202741,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-reporting-services` (#202741)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 1 plugin(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/screenshotting-plugin` |\r\n`x-pack/platform/plugins/shared/screenshotting` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-cli-dev-mode/src/watcher.ts\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js\r\n./src/dev/precommit_hook/casing_check_config.js\r\n./tsconfig.base.json\r\n./x-pack/.gitignore\r\n./x-pack/.i18nrc.json\r\n./x-pack/platform/plugins/shared/screenshotting/README.md\r\n./x-pack/platform/plugins/shared/screenshotting/jest.config.js\r\n./x-pack/platform/plugins/shared/screenshotting/jest.integration.config.js\r\n./x-pack/platform/plugins/shared/screenshotting/server/screenshots/screenshots.test.ts\r\n./x-pack/plugins/lens/public/app_plugin/share_action.ts\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nx-pack/platform/plugins/shared/screenshotting/jest.config.js:10\r\nx-pack/platform/plugins/shared/screenshotting/jest.integration.config.js:10\r\nx-pack/platform/plugins/shared/screenshotting/server/formats/pdf/pdf_maker/worker_src_harness.js:14\r\nx-pack/platform/plugins/shared/screenshotting/tsconfig.json:10\r\nx-pack/platform/plugins/shared/screenshotting/tsconfig.json:14\r\nx-pack/platform/plugins/shared/screenshotting/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"0e2fc8f4e22a9dd41fc0b0f3c0ea2bd448a6c73e"}}]}] BACKPORT-->
…na-reporting-services` (elastic#202741) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > This PR has been auto-generated. > Do not attempt to push any changes unless you know what you are doing. > Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. #### 1 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/screenshotting-plugin` | `x-pack/platform/plugins/shared/screenshotting` | <details> <summary>Updated references</summary> ``` ./docs/developer/plugin-list.asciidoc ./package.json ./packages/kbn-cli-dev-mode/src/watcher.ts ./packages/kbn-repo-packages/package-map.json ./packages/kbn-ts-projects/config-paths.json ./src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js ./src/dev/precommit_hook/casing_check_config.js ./tsconfig.base.json ./x-pack/.gitignore ./x-pack/.i18nrc.json ./x-pack/platform/plugins/shared/screenshotting/README.md ./x-pack/platform/plugins/shared/screenshotting/jest.config.js ./x-pack/platform/plugins/shared/screenshotting/jest.integration.config.js ./x-pack/platform/plugins/shared/screenshotting/server/screenshots/screenshots.test.ts ./x-pack/plugins/lens/public/app_plugin/share_action.ts ./yarn.lock ``` </details> <details> <summary>Updated relative paths</summary> ``` x-pack/platform/plugins/shared/screenshotting/jest.config.js:10 x-pack/platform/plugins/shared/screenshotting/jest.integration.config.js:10 x-pack/platform/plugins/shared/screenshotting/server/formats/pdf/pdf_maker/worker_src_harness.js:14 x-pack/platform/plugins/shared/screenshotting/tsconfig.json:10 x-pack/platform/plugins/shared/screenshotting/tsconfig.json:14 x-pack/platform/plugins/shared/screenshotting/tsconfig.json:2 ``` </details> <details> <summary>Script errors</summary> ``` ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]
andplugins[\/\\]
patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.ts
to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.ts
and.js
files listed in the sections below, as some of them contain relative paths that have been updated.Note
Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.
1 plugin(s) are going to be relocated:
@kbn/screenshotting-plugin
x-pack/platform/plugins/shared/screenshotting
Updated references
Updated relative paths