Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] JOIN command Traversal API and prety-printing support #202750

Merged
merged 9 commits into from
Dec 6, 2024
Merged

[ES|QL] JOIN command Traversal API and prety-printing support #202750

merged 9 commits into from
Dec 6, 2024

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Dec 3, 2024 •
edited by kibanamachine
Loading

Summary

Partially addresses #200858

  • Add support for the new JOIN command and AS expression in Traversal API: Walker and Visitor
  • Adds support for the new JOINcommand and AS expression in the pretty-printer.
  • Fixes some parser bugs related to the JOIN command.

Checklist

@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.18.0 labels Dec 5, 2024
@vadimkibana vadimkibana marked this pull request as ready for review December 5, 2024 09:19
@vadimkibana vadimkibana requested a review from a team as a code owner December 5, 2024 09:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@vadimkibana vadimkibana enabled auto-merge (squash) December 5, 2024 13:36
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/esql-ast 36 25 -11

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.5MB 3.5MB +1.1KB

History

stratoula
stratoula approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 🙌

@vadimkibana vadimkibana merged commit 79c0827 into elastic:main Dec 6, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12194956855

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 6, 2024
@vadimkibana
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
fba4277 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 79c0827)
@kibanamachine kibanamachine mentioned this pull request Dec 6, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 6, 2024
@kibanamachine @vadimkibana
[8.x] [ES|QL] `JOIN` command Traversal API and prety-printi…
9db2f95 
…ng support (#202750) (#203209)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] `JOIN` command Traversal API and prety-printing
support (#202750)](#202750)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vadim
Kibana","email":"82822460+vadimkibana@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-06T07:44:23Z","message":"[ES|QL]
`JOIN` command Traversal API and prety-printing support (#202750)\n\n##
Summary\r\n\r\nPartially addresses
https://github.com/elastic/kibana/issues/200858\r\n\r\n- Add support for
the new `JOIN` command and `AS` expression in\r\nTraversal API: `Walker`
and `Visitor`\r\n- Adds support for the new `JOIN`command and `AS`
expression in the\r\npretty-printer.\r\n- Fixes some parser bugs related
to the `JOIN` command.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"79c0827128a42b6c9bb198c557b6c4c093d6bbfa","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.18.0"],"title":"[ES|QL]
`JOIN` command Traversal API and prety-printing
support","number":202750,"url":"https://github.com/elastic/kibana/pull/202750","mergeCommit":{"message":"[ES|QL]
`JOIN` command Traversal API and prety-printing support (#202750)\n\n##
Summary\r\n\r\nPartially addresses
https://github.com/elastic/kibana/issues/200858\r\n\r\n- Add support for
the new `JOIN` command and `AS` expression in\r\nTraversal API: `Walker`
and `Visitor`\r\n- Adds support for the new `JOIN`command and `AS`
expression in the\r\npretty-printer.\r\n- Fixes some parser bugs related
to the `JOIN` command.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"79c0827128a42b6c9bb198c557b6c4c093d6bbfa"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202750","number":202750,"mergeCommit":{"message":"[ES|QL]
`JOIN` command Traversal API and prety-printing support (#202750)\n\n##
Summary\r\n\r\nPartially addresses
https://github.com/elastic/kibana/issues/200858\r\n\r\n- Add support for
the new `JOIN` command and `AS` expression in\r\nTraversal API: `Walker`
and `Visitor`\r\n- Adds support for the new `JOIN`command and `AS`
expression in the\r\npretty-printer.\r\n- Fixes some parser bugs related
to the `JOIN` command.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"79c0827128a42b6c9bb198c557b6c4c093d6bbfa"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>
markov00 pushed a commit to markov00/kibana that referenced this pull request Dec 7, 2024
@vadimkibana @markov00
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
f6e52bc 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@vadimkibana @SoniaSanzV
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
ac8a81d 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@vadimkibana @SoniaSanzV
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
60383e1 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@vadimkibana @CAWilson94
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
311ed58 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
@vadimkibana @Samiul-TheSoccerFan
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
1fec9be 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
@vadimkibana @mykolaharmash
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
f4a4998 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@vadimkibana @CAWilson94
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
9e107fb 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes review Team:ESQL ES|QL related features in Kibana v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadimkibana @elasticmachine @kibanamachine @stratoula