Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/logstash #202756

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -843,6 +843,7 @@ x-pack/platform/plugins/private/data_visualizer @elastic/ml-ui
x-pack/platform/plugins/private/grokdebugger @elastic/kibana-management
x-pack/platform/plugins/private/index_lifecycle_management @elastic/kibana-management
x-pack/platform/plugins/private/license_api_guard @elastic/kibana-management
x-pack/platform/plugins/private/logstash @elastic/logstash
x-pack/platform/plugins/private/painless_lab @elastic/kibana-management
x-pack/platform/plugins/private/remote_clusters @elastic/kibana-management
x-pack/platform/plugins/private/rollup @elastic/kibana-management
Expand Down Expand Up @@ -897,7 +898,6 @@ x-pack/plugins/global_search_providers @elastic/appex-sharedux
x-pack/plugins/graph @elastic/kibana-visualizations
x-pack/plugins/lens @elastic/kibana-visualizations
x-pack/plugins/licensing @elastic/kibana-core
x-pack/plugins/logstash @elastic/logstash
x-pack/plugins/maps @elastic/kibana-presentation
x-pack/plugins/monitoring @elastic/stack-monitoring
x-pack/plugins/monitoring_collection @elastic/stack-monitoring
Expand Down Expand Up @@ -2561,7 +2561,7 @@ x-pack/solutions/security/plugins/security_solution/server/lib/security_integrat
/x-pack/test/functional/page_objects/logstash_page.ts @elastic/logstash
/x-pack/test/functional/apps/logstash @elastic/logstash
/x-pack/test/api_integration/apis/logstash @elastic/logstash
#CC# /x-pack/plugins/logstash/ @elastic/logstash
#CC# /x-pack/platform/plugins/private/logstash/ @elastic/logstash

# EUI team
/src/plugins/kibana_react/public/page_template/ @elastic/eui-team @elastic/appex-sharedux
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ using the CURL scripts in the scripts folder.
|Exposes the shared components and APIs to access and visualize logs.


|{kib-repo}blob/{branch}/x-pack/plugins/logstash[logstash]
|{kib-repo}blob/{branch}/x-pack/platform/plugins/private/logstash[logstash]
|WARNING: Missing README.


Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@
"@kbn/logs-data-access-plugin": "link:x-pack/platform/plugins/shared/logs_data_access",
"@kbn/logs-explorer-plugin": "link:x-pack/solutions/observability/plugins/logs_explorer",
"@kbn/logs-shared-plugin": "link:x-pack/platform/plugins/shared/logs_shared",
"@kbn/logstash-plugin": "link:x-pack/plugins/logstash",
"@kbn/logstash-plugin": "link:x-pack/platform/plugins/private/logstash",
"@kbn/managed-content-badge": "link:packages/kbn-managed-content-badge",
"@kbn/management-cards-navigation": "link:src/platform/packages/shared/kbn-management/cards_navigation",
"@kbn/management-plugin": "link:src/platform/plugins/shared/management",
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1176,8 +1176,8 @@
"@kbn/logs-explorer-plugin/*": ["x-pack/solutions/observability/plugins/logs_explorer/*"],
"@kbn/logs-shared-plugin": ["x-pack/platform/plugins/shared/logs_shared"],
"@kbn/logs-shared-plugin/*": ["x-pack/platform/plugins/shared/logs_shared/*"],
"@kbn/logstash-plugin": ["x-pack/plugins/logstash"],
"@kbn/logstash-plugin/*": ["x-pack/plugins/logstash/*"],
"@kbn/logstash-plugin": ["x-pack/platform/plugins/private/logstash"],
"@kbn/logstash-plugin/*": ["x-pack/platform/plugins/private/logstash/*"],
"@kbn/managed-content-badge": ["packages/kbn-managed-content-badge"],
"@kbn/managed-content-badge/*": ["packages/kbn-managed-content-badge/*"],
"@kbn/managed-vscode-config": ["packages/kbn-managed-vscode-config"],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/.i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"xpack.licensing": "plugins/licensing",
"xpack.lists": "solutions/security/plugins/lists",
"xpack.logstash": [
"plugins/logstash"
"platform/plugins/private/logstash"
],
"xpack.main": "legacy/plugins/xpack_main",
"xpack.maps": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@

module.exports = {
preset: '@kbn/test',
rootDir: '../../..',
roots: ['<rootDir>/x-pack/plugins/logstash'],
coverageDirectory: '<rootDir>/target/kibana-coverage/jest/x-pack/plugins/logstash',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/platform/plugins/private/logstash'],
coverageDirectory:
'<rootDir>/target/kibana-coverage/jest/x-pack/platform/plugins/private/logstash',
coverageReporters: ['text', 'html'],
collectCoverageFrom: [
'<rootDir>/x-pack/plugins/logstash/{common,public,server}/**/*.{js,ts,tsx}',
'<rootDir>/x-pack/platform/plugins/private/logstash/{common,public,server}/**/*.{js,ts,tsx}',
],
};
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

{
"extends": "../../../tsconfig.base.json",
"extends": "../../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types",
},
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6169,7 +6169,7 @@
version "0.0.0"
uid ""

"@kbn/logstash-plugin@link:x-pack/plugins/logstash":
"@kbn/logstash-plugin@link:x-pack/platform/plugins/private/logstash":
version "0.0.0"
uid ""

Expand Down