Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Fix Cypress test to work with refactored Roles page #202770

Merged
merged 10 commits into from
Dec 5, 2024
Merged

[Security Solution][Endpoint] Fix Cypress test to work with refactored Roles page #202770

merged 10 commits into from
Dec 5, 2024

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Dec 3, 2024 •
edited by kibanamachine
Loading

Summary

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 labels Dec 3, 2024
@paul-tavares paul-tavares self-assigned this Dec 3, 2024
@paul-tavares
Copy link
Contributor Author

/ci

@paul-tavares paul-tavares mentioned this pull request Dec 3, 2024
Closed
@paul-tavares
Copy link
Contributor Author

Serverless MKI CI run triggered: https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-defend-workflows/builds/1702

@paul-tavares paul-tavares marked this pull request as ready for review December 3, 2024 16:56
@paul-tavares paul-tavares requested a review from a team as a code owner December 3, 2024 16:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@paul-tavares
Copy link
Contributor Author

Second MKI test suite run: https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-defend-workflows/builds/1704

@paul-tavares
Copy link
Contributor Author

3rd MKI run: https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-defend-workflows/builds/1709

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @paul-tavares

@paul-tavares paul-tavares mentioned this pull request Dec 5, 2024
Closed
tomsonpl
tomsonpl approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement! Thanks for doing this 👍

gergoabraham
gergoabraham approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@paul-tavares paul-tavares enabled auto-merge (squash) December 5, 2024 15:45
@paul-tavares paul-tavares merged commit 5262902 into elastic:main Dec 5, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12183387830

@paul-tavares paul-tavares deleted the task/olm-200962-fix-filaing-spaces-rbac-test branch December 5, 2024 15:57
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202770

Questions ?

Please refer to the Backport tool documentation

@paul-tavares paul-tavares mentioned this pull request Dec 5, 2024
Merged
@paul-tavares
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

paul-tavares added a commit to paul-tavares/kibana that referenced this pull request Dec 5, 2024
@paul-tavares
[Security Solution][Endpoint] Fix Cypress test to work with refactore…
f1fadc2 
…d Roles page (elastic#202770)

## Summary

- Fixes cypress tests for space awareness RBAC checks to work with the
recent changes to the core Role page
    - Fixes elastic#200962
    - Fixes elastic#200967
- Enables test file for runs on Serverless MKI environments

(cherry picked from commit 5262902)

# Conflicts:
#	x-pack/plugins/security_solution/public/management/cypress/e2e/rbac/endpoint_role_rbac.cy.ts
paul-tavares added a commit that referenced this pull request Dec 5, 2024
@paul-tavares
[8.x] [Security Solution][Endpoint] Fix Cypress test to work with ref…
e9cb539 
…actored Roles page (#202770) (#203131)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Endpoint] Fix Cypress test to work with
refactored Roles page
(#202770)](#202770)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Paul
Tavares","email":"56442535+paul-tavares@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-05T15:56:53Z","message":"[Security
Solution][Endpoint] Fix Cypress test to work with refactored Roles page
(#202770)\n\n## Summary\r\n\r\n- Fixes cypress tests for space awareness
RBAC checks to work with the\r\nrecent changes to the core Role page\r\n
- Fixes #200962\r\n - Fixes #200967\r\n- Enables test file for runs on
Serverless MKI
environments","sha":"5262902a86a6b2b549e61b81037ce77933e2d484","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend
Workflows","backport:prev-minor","v8.18.0"],"number":202770,"url":"https://github.com/elastic/kibana/pull/202770","mergeCommit":{"message":"[Security
Solution][Endpoint] Fix Cypress test to work with refactored Roles page
(#202770)\n\n## Summary\r\n\r\n- Fixes cypress tests for space awareness
RBAC checks to work with the\r\nrecent changes to the core Role page\r\n
- Fixes #200962\r\n - Fixes #200967\r\n- Enables test file for runs on
Serverless MKI
environments","sha":"5262902a86a6b2b549e61b81037ce77933e2d484"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202770","number":202770,"mergeCommit":{"message":"[Security
Solution][Endpoint] Fix Cypress test to work with refactored Roles page
(#202770)\n\n## Summary\r\n\r\n- Fixes cypress tests for space awareness
RBAC checks to work with the\r\nrecent changes to the core Role page\r\n
- Fixes #200962\r\n - Fixes #200967\r\n- Enables test file for runs on
Serverless MKI
environments","sha":"5262902a86a6b2b549e61b81037ce77933e2d484"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@paul-tavares @SoniaSanzV
[Security Solution][Endpoint] Fix Cypress test to work with refactore…
9c91cca 
…d Roles page (elastic#202770)

## Summary

- Fixes cypress tests for space awareness RBAC checks to work with the
recent changes to the core Role page
    - Fixes elastic#200962
    - Fixes elastic#200967
- Enables test file for runs on Serverless MKI environments
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@paul-tavares @SoniaSanzV
[Security Solution][Endpoint] Fix Cypress test to work with refactore…
f5e871b 
…d Roles page (elastic#202770)

## Summary

- Fixes cypress tests for space awareness RBAC checks to work with the
recent changes to the core Role page
    - Fixes elastic#200962
    - Fixes elastic#200967
- Enables test file for runs on Serverless MKI environments
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@paul-tavares @CAWilson94
[Security Solution][Endpoint] Fix Cypress test to work with refactore…
6a27f4f 
…d Roles page (elastic#202770)

## Summary

- Fixes cypress tests for space awareness RBAC checks to work with the
recent changes to the core Role page
    - Fixes elastic#200962
    - Fixes elastic#200967
- Enables test file for runs on Serverless MKI environments
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
@paul-tavares @Samiul-TheSoccerFan
[Security Solution][Endpoint] Fix Cypress test to work with refactore…
bb1099a 
…d Roles page (elastic#202770)

## Summary

- Fixes cypress tests for space awareness RBAC checks to work with the
recent changes to the core Role page
    - Fixes elastic#200962
    - Fixes elastic#200967
- Enables test file for runs on Serverless MKI environments
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
@paul-tavares @mykolaharmash
[Security Solution][Endpoint] Fix Cypress test to work with refactore…
0a84c14 
…d Roles page (elastic#202770)

## Summary

- Fixes cypress tests for space awareness RBAC checks to work with the
recent changes to the core Role page
    - Fixes elastic#200962
    - Fixes elastic#200967
- Enables test file for runs on Serverless MKI environments
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@paul-tavares @CAWilson94
[Security Solution][Endpoint] Fix Cypress test to work with refactore…
3fc2875 
…d Roles page (elastic#202770)

## Summary

- Fixes cypress tests for space awareness RBAC checks to work with the
recent changes to the core Role page
    - Fixes elastic#200962
    - Fixes elastic#200967
- Enables test file for runs on Serverless MKI environments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gergoabraham gergoabraham gergoabraham approved these changes

@tomsonpl tomsonpl tomsonpl approved these changes

Assignees

@paul-tavares paul-tavares

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
5 participants
@paul-tavares @elasticmachine @kibanamachine @tomsonpl @gergoabraham