Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Refactor failing tests to avoid timeouts #202773

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Dec 3, 2024

Summary

Avoid queries with timeouts and unnecessary waitFor calls.

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@kpollich kpollich added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 3, 2024
@kpollich kpollich self-assigned this Dec 3, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@kpollich
Copy link
Member Author

kpollich commented Dec 6, 2024

Removing the 4500ms timeout causes a ton of tests making use of waitFor to start failing, so that doesn't seem doable.

@kpollich
Copy link
Member Author

kpollich commented Dec 6, 2024

@elasticmachine merge upstream

@kpollich
Copy link
Member Author

kpollich commented Dec 6, 2024

Most recent run with some policy editor tests shows some flaky failures: https://buildkite.com/elastic/kibana-pull-request/builds/257836#01939c67-2b18-4210-8510-a3756ed238c1

@kpollich
Copy link
Member Author

kpollich commented Dec 9, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 13, 2024

💔 Build Failed

Failed CI Steps

History

cc @kpollich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants