Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs AI Assistant] Manual migration for routes with access tag #202817

Merged
merged 11 commits into from
Dec 4, 2024
Merged

[Obs AI Assistant] Manual migration for routes with access tag #202817

merged 11 commits into from
Dec 4, 2024

Conversation

viduni94
Copy link
Contributor

@viduni94 viduni94 commented Dec 3, 2024 •
edited by kibanamachine
Loading

Summary

Problem

tags: [access:ai_assistant] is deprecated.

Solution

All the routes that use this tag needs to be migrated to the authz: requiredPrivileges property.

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@viduni94 viduni94 added release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant backport:version Backport to applied version labels Authz: API migration v8.18.0 labels Dec 3, 2024
@viduni94 viduni94 self-assigned this Dec 3, 2024
@viduni94 viduni94 requested a review from a team as a code owner December 3, 2024 21:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@viduni94 viduni94 force-pushed the manual-migration-for-routes-with-access-tag branch from ccd26ae to 58eb548 Compare December 3, 2024 21:19
@viduni94 viduni94 mentioned this pull request Dec 3, 2024
Closed
1 task
@viduni94 viduni94 force-pushed the manual-migration-for-routes-with-access-tag branch from 58eb548 to cd9d171 Compare December 3, 2024 21:46
@sorenlouv sorenlouv mentioned this pull request Dec 3, 2024
Merged
7 tasks
@viduni94 viduni94 requested a review from sorenlouv December 4, 2024 00:38
@viduni94 viduni94 changed the title Manual migration for routes with access tag [Obs AI Assistant] Manual migration for routes with access tag Dec 4, 2024
@viduni94 viduni94 force-pushed the manual-migration-for-routes-with-access-tag branch from 84227a1 to 4cfde64 Compare December 4, 2024 13:34
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 4, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 4cfde64
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202817-4cfde64fe26a

Metrics [docs]

✅ unchanged

History

cc @viduni94

@viduni94 viduni94 merged commit d669c83 into elastic:main Dec 4, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12167651539

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 4, 2024
@viduni94
[Obs AI Assistant] Manual migration for routes with access tag (elast…
44bab10 
…ic#202817)

## Summary

### Problem
`tags: [access:ai_assistant]` is deprecated.

### Solution
All the routes that use this tag needs to be migrated to the `authz`:
`requiredPrivileges` property.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit d669c83)
@kibanamachine kibanamachine mentioned this pull request Dec 4, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 4, 2024
@kibanamachine @viduni94
[8.x] [Obs AI Assistant] Manual migration for routes with access tag (#…
49a2c8c 
…202817) (#203013)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs AI Assistant] Manual migration for routes with access tag
(#202817)](#202817)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Viduni
Wickramarachchi","email":"viduni.wickramarachchi@elastic.co"},"sourceCommit":{"committedDate":"2024-12-04T20:21:25Z","message":"[Obs
AI Assistant] Manual migration for routes with access tag
(#202817)\n\n## Summary\r\n\r\n### Problem\r\n`tags:
[access:ai_assistant]` is deprecated. \r\n\r\n### Solution\r\nAll the
routes that use this tag needs to be migrated to the
`authz`:\r\n`requiredPrivileges` property.\r\n\r\n### Checklist\r\n\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] The PR
description includes the appropriate Release Notes section,\r\nand the
correct `release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d669c83be8d7d79e157786dce9742a55c3e69a6b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Obs
AI
Assistant","ci:project-deploy-observability","backport:version","Authz:
API migration","v8.18.0"],"title":"[Obs AI Assistant] Manual migration
for routes with access
tag","number":202817,"url":"https://github.com/elastic/kibana/pull/202817","mergeCommit":{"message":"[Obs
AI Assistant] Manual migration for routes with access tag
(#202817)\n\n## Summary\r\n\r\n### Problem\r\n`tags:
[access:ai_assistant]` is deprecated. \r\n\r\n### Solution\r\nAll the
routes that use this tag needs to be migrated to the
`authz`:\r\n`requiredPrivileges` property.\r\n\r\n### Checklist\r\n\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] The PR
description includes the appropriate Release Notes section,\r\nand the
correct `release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d669c83be8d7d79e157786dce9742a55c3e69a6b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202817","number":202817,"mergeCommit":{"message":"[Obs
AI Assistant] Manual migration for routes with access tag
(#202817)\n\n## Summary\r\n\r\n### Problem\r\n`tags:
[access:ai_assistant]` is deprecated. \r\n\r\n### Solution\r\nAll the
routes that use this tag needs to be migrated to the
`authz`:\r\n`requiredPrivileges` property.\r\n\r\n### Checklist\r\n\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] The PR
description includes the appropriate Release Notes section,\r\nand the
correct `release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d669c83be8d7d79e157786dce9742a55c3e69a6b"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@viduni94 @SoniaSanzV
[Obs AI Assistant] Manual migration for routes with access tag (elast…
632b79f 
…ic#202817)

## Summary

### Problem
`tags: [access:ai_assistant]` is deprecated. 

### Solution
All the routes that use this tag needs to be migrated to the `authz`:
`requiredPrivileges` property.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@viduni94 @SoniaSanzV
[Obs AI Assistant] Manual migration for routes with access tag (elast…
6895d34 
…ic#202817)

## Summary

### Problem
`tags: [access:ai_assistant]` is deprecated. 

### Solution
All the routes that use this tag needs to be migrated to the `authz`:
`requiredPrivileges` property.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@viduni94 @CAWilson94
[Obs AI Assistant] Manual migration for routes with access tag (elast…
c0c6e19 
…ic#202817)

## Summary

### Problem
`tags: [access:ai_assistant]` is deprecated. 

### Solution
All the routes that use this tag needs to be migrated to the `authz`:
`requiredPrivileges` property.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
@viduni94 @Samiul-TheSoccerFan
[Obs AI Assistant] Manual migration for routes with access tag (elast…
bb57202 
…ic#202817)

## Summary

### Problem
`tags: [access:ai_assistant]` is deprecated. 

### Solution
All the routes that use this tag needs to be migrated to the `authz`:
`requiredPrivileges` property.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This was referenced Dec 11, 2024
Closed
Closed
Closed
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@viduni94 @CAWilson94
[Obs AI Assistant] Manual migration for routes with access tag (elast…
3d31f8c 
…ic#202817)

## Summary

### Problem
`tags: [access:ai_assistant]` is deprecated. 

### Solution
All the routes that use this tag needs to be migrated to the `authz`:
`requiredPrivileges` property.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@neptunian neptunian mentioned this pull request Dec 18, 2024
Open
5 tasks
@viduni94 viduni94 mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@viduni94 viduni94

Labels
Authz: API migration backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viduni94 @elasticmachine @kibanamachine @sorenlouv