Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/security-detections-response #202847

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Dec 3, 2024

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

  • This PR has been auto-generated.
  • Any manual contributions will be lost if the 'relocate' script is re-run.
  • Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
  • Please use #sustainable_kibana_architecture Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.

1 packages(s) are going to be relocated:

Id Target folder
@kbn/rule-data-utils src/platform/packages/shared/kbn-rule-data-utils
Updated references
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/shared/kbn-rule-data-utils/jest.config.js
./src/platform/plugins/shared/discover/tsconfig.type_check.json
./tsconfig.base.json
./tsconfig.base.type_check.json
./tsconfig.refs.json
./x-pack/examples/triggers_actions_ui_example/tsconfig.type_check.json
./x-pack/packages/observability/alert_details/tsconfig.type_check.json
./x-pack/packages/observability/alerting_test_data/tsconfig.type_check.json
./x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json
./x-pack/plugins/alerting/tsconfig.type_check.json
./x-pack/plugins/cases/tsconfig.type_check.json
./x-pack/plugins/ml/tsconfig.type_check.json
./x-pack/plugins/observability_solution/apm/tsconfig.type_check.json
./x-pack/plugins/observability_solution/infra/tsconfig.type_check.json
./x-pack/plugins/observability_solution/investigate_app/tsconfig.type_check.json
./x-pack/plugins/observability_solution/observability/tsconfig.type_check.json
./x-pack/plugins/observability_solution/observability_logs_explorer/tsconfig.type_check.json
./x-pack/plugins/observability_solution/observability_shared/tsconfig.type_check.json
./x-pack/plugins/observability_solution/slo/tsconfig.type_check.json
./x-pack/plugins/observability_solution/synthetics/tsconfig.type_check.json
./x-pack/plugins/observability_solution/uptime/tsconfig.type_check.json
./x-pack/plugins/rule_registry/tsconfig.type_check.json
./x-pack/plugins/stack_alerts/tsconfig.type_check.json
./x-pack/plugins/transform/tsconfig.type_check.json
./x-pack/plugins/triggers_actions_ui/tsconfig.type_check.json
./x-pack/solutions/security/plugins/timelines/tsconfig.type_check.json
./x-pack/test/alerting_api_integration/common/plugins/alerts/tsconfig.type_check.json
./x-pack/test/security_solution_api_integration/tsconfig.type_check.json
./x-pack/test/tsconfig.type_check.json
./x-pack/test_serverless/tsconfig.type_check.json
./yarn.lock
.github/CODEOWNERS
Updated relative paths
src/platform/packages/shared/kbn-rule-data-utils/jest.config.js:12
src/platform/packages/shared/kbn-rule-data-utils/tsconfig.json:2
src/platform/packages/shared/kbn-rule-data-utils/tsconfig.type_check.json:2

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Detection Engine Security Solution Detection Engine Area labels Dec 4, 2024
@gsoldevila gsoldevila marked this pull request as ready for review December 4, 2024 08:24
@gsoldevila gsoldevila requested review from a team as code owners December 4, 2024 08:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-security-detections-response branch from 58f33a0 to 6408e10 Compare December 5, 2024 15:37
@gsoldevila gsoldevila requested a review from a team as a code owner December 5, 2024 15:37
@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-security-detections-response branch from 6408e10 to b0167fb Compare December 10, 2024 13:53
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These SEEM to be file moves only, and I don't think we own these files, but I'm not entirely sure. The file filter is weird because it says the PR has only changed 22 files overall but the "Owned by you" filter says we own 34 files.

Screenshot 2024-12-16 at 3 07 06 PM

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-security-detections-response branch from f8bf591 to 8425534 Compare December 16, 2024 20:58
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / Severity form field selects the correct value when changed assigned to me

Metrics [docs]

✅ unchanged

History

@rudolf rudolf added the plugin groups Relocate all plugins and packages under their respective platform/solution groups label Dec 18, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

@rudolf rudolf removed the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Dec 18, 2024
@marshallmain marshallmain added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 18, 2024
@marshallmain marshallmain merged commit e6a07e6 into elastic:main Dec 18, 2024
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12400551433

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202847

Questions ?

Please refer to the Backport tool documentation

marshallmain pushed a commit to marshallmain/kibana that referenced this pull request Dec 18, 2024
…rity-detections-response` (elastic#202847)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow
the steps describe
[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).

#### 1 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/rule-data-utils` |
`src/platform/packages/shared/kbn-rule-data-utils` |

<details >
<summary>Updated references</summary>

```
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/shared/kbn-rule-data-utils/jest.config.js
./src/platform/plugins/shared/discover/tsconfig.type_check.json
./tsconfig.base.json
./tsconfig.base.type_check.json
./tsconfig.refs.json
./x-pack/examples/triggers_actions_ui_example/tsconfig.type_check.json
./x-pack/packages/observability/alert_details/tsconfig.type_check.json
./x-pack/packages/observability/alerting_test_data/tsconfig.type_check.json
./x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json
./x-pack/plugins/alerting/tsconfig.type_check.json
./x-pack/plugins/cases/tsconfig.type_check.json
./x-pack/plugins/ml/tsconfig.type_check.json
./x-pack/plugins/observability_solution/apm/tsconfig.type_check.json
./x-pack/plugins/observability_solution/infra/tsconfig.type_check.json
./x-pack/plugins/observability_solution/investigate_app/tsconfig.type_check.json
./x-pack/plugins/observability_solution/observability/tsconfig.type_check.json
./x-pack/plugins/observability_solution/observability_logs_explorer/tsconfig.type_check.json
./x-pack/plugins/observability_solution/observability_shared/tsconfig.type_check.json
./x-pack/plugins/observability_solution/slo/tsconfig.type_check.json
./x-pack/plugins/observability_solution/synthetics/tsconfig.type_check.json
./x-pack/plugins/observability_solution/uptime/tsconfig.type_check.json
./x-pack/plugins/rule_registry/tsconfig.type_check.json
./x-pack/plugins/stack_alerts/tsconfig.type_check.json
./x-pack/plugins/transform/tsconfig.type_check.json
./x-pack/plugins/triggers_actions_ui/tsconfig.type_check.json
./x-pack/solutions/security/plugins/timelines/tsconfig.type_check.json
./x-pack/test/alerting_api_integration/common/plugins/alerts/tsconfig.type_check.json
./x-pack/test/security_solution_api_integration/tsconfig.type_check.json
./x-pack/test/tsconfig.type_check.json
./x-pack/test_serverless/tsconfig.type_check.json
./yarn.lock
.github/CODEOWNERS
```

</details><details >
<summary>Updated relative paths</summary>

```
src/platform/packages/shared/kbn-rule-data-utils/jest.config.js:12
src/platform/packages/shared/kbn-rule-data-utils/tsconfig.json:2
src/platform/packages/shared/kbn-rule-data-utils/tsconfig.type_check.json:2
```

</details>

Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>
(cherry picked from commit e6a07e6)

# Conflicts:
#	.github/CODEOWNERS
@marshallmain
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

marshallmain added a commit that referenced this pull request Dec 18, 2024
…c/security-detections-response` (#202847) (#204833)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Sustainable Kibana Architecture: Move modules owned by
`@elastic/security-detections-response`
(#202847)](#202847)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-12-18T20:10:50Z","message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-detections-response` (#202847)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve
merge conflicts? Please follow\r\nthe steps
describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n####
1 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder
|\r\n| -- | ------------- |\r\n| `@kbn/rule-data-utils`
|\r\n`src/platform/packages/shared/kbn-rule-data-utils`
|\r\n\r\n\r\n<details >\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/shared/kbn-rule-data-utils/jest.config.js\r\n./src/platform/plugins/shared/discover/tsconfig.type_check.json\r\n./tsconfig.base.json\r\n./tsconfig.base.type_check.json\r\n./tsconfig.refs.json\r\n./x-pack/examples/triggers_actions_ui_example/tsconfig.type_check.json\r\n./x-pack/packages/observability/alert_details/tsconfig.type_check.json\r\n./x-pack/packages/observability/alerting_test_data/tsconfig.type_check.json\r\n./x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json\r\n./x-pack/plugins/alerting/tsconfig.type_check.json\r\n./x-pack/plugins/cases/tsconfig.type_check.json\r\n./x-pack/plugins/ml/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/apm/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/infra/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/investigate_app/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/observability/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/observability_logs_explorer/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/observability_shared/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/slo/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/synthetics/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/uptime/tsconfig.type_check.json\r\n./x-pack/plugins/rule_registry/tsconfig.type_check.json\r\n./x-pack/plugins/stack_alerts/tsconfig.type_check.json\r\n./x-pack/plugins/transform/tsconfig.type_check.json\r\n./x-pack/plugins/triggers_actions_ui/tsconfig.type_check.json\r\n./x-pack/solutions/security/plugins/timelines/tsconfig.type_check.json\r\n./x-pack/test/alerting_api_integration/common/plugins/alerts/tsconfig.type_check.json\r\n./x-pack/test/security_solution_api_integration/tsconfig.type_check.json\r\n./x-pack/test/tsconfig.type_check.json\r\n./x-pack/test_serverless/tsconfig.type_check.json\r\n./yarn.lock\r\n.github/CODEOWNERS\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nsrc/platform/packages/shared/kbn-rule-data-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-rule-data-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-rule-data-utils/tsconfig.type_check.json:2\r\n```\r\n\r\n</details>\r\n\r\nCo-authored-by:
Marshall Main
<55718608+marshallmain@users.noreply.github.com>","sha":"e6a07e63829e116c8e809a3923b7b0fe239e1318","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Detection
Engine","plugin
groups"],"number":202847,"url":"https://github.com/elastic/kibana/pull/202847","mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-detections-response` (#202847)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve
merge conflicts? Please follow\r\nthe steps
describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n####
1 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder
|\r\n| -- | ------------- |\r\n| `@kbn/rule-data-utils`
|\r\n`src/platform/packages/shared/kbn-rule-data-utils`
|\r\n\r\n\r\n<details >\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/shared/kbn-rule-data-utils/jest.config.js\r\n./src/platform/plugins/shared/discover/tsconfig.type_check.json\r\n./tsconfig.base.json\r\n./tsconfig.base.type_check.json\r\n./tsconfig.refs.json\r\n./x-pack/examples/triggers_actions_ui_example/tsconfig.type_check.json\r\n./x-pack/packages/observability/alert_details/tsconfig.type_check.json\r\n./x-pack/packages/observability/alerting_test_data/tsconfig.type_check.json\r\n./x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json\r\n./x-pack/plugins/alerting/tsconfig.type_check.json\r\n./x-pack/plugins/cases/tsconfig.type_check.json\r\n./x-pack/plugins/ml/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/apm/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/infra/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/investigate_app/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/observability/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/observability_logs_explorer/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/observability_shared/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/slo/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/synthetics/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/uptime/tsconfig.type_check.json\r\n./x-pack/plugins/rule_registry/tsconfig.type_check.json\r\n./x-pack/plugins/stack_alerts/tsconfig.type_check.json\r\n./x-pack/plugins/transform/tsconfig.type_check.json\r\n./x-pack/plugins/triggers_actions_ui/tsconfig.type_check.json\r\n./x-pack/solutions/security/plugins/timelines/tsconfig.type_check.json\r\n./x-pack/test/alerting_api_integration/common/plugins/alerts/tsconfig.type_check.json\r\n./x-pack/test/security_solution_api_integration/tsconfig.type_check.json\r\n./x-pack/test/tsconfig.type_check.json\r\n./x-pack/test_serverless/tsconfig.type_check.json\r\n./yarn.lock\r\n.github/CODEOWNERS\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nsrc/platform/packages/shared/kbn-rule-data-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-rule-data-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-rule-data-utils/tsconfig.type_check.json:2\r\n```\r\n\r\n</details>\r\n\r\nCo-authored-by:
Marshall Main
<55718608+marshallmain@users.noreply.github.com>","sha":"e6a07e63829e116c8e809a3923b7b0fe239e1318"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202847","number":202847,"mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-detections-response` (#202847)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve
merge conflicts? Please follow\r\nthe steps
describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n####
1 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder
|\r\n| -- | ------------- |\r\n| `@kbn/rule-data-utils`
|\r\n`src/platform/packages/shared/kbn-rule-data-utils`
|\r\n\r\n\r\n<details >\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/shared/kbn-rule-data-utils/jest.config.js\r\n./src/platform/plugins/shared/discover/tsconfig.type_check.json\r\n./tsconfig.base.json\r\n./tsconfig.base.type_check.json\r\n./tsconfig.refs.json\r\n./x-pack/examples/triggers_actions_ui_example/tsconfig.type_check.json\r\n./x-pack/packages/observability/alert_details/tsconfig.type_check.json\r\n./x-pack/packages/observability/alerting_test_data/tsconfig.type_check.json\r\n./x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json\r\n./x-pack/plugins/alerting/tsconfig.type_check.json\r\n./x-pack/plugins/cases/tsconfig.type_check.json\r\n./x-pack/plugins/ml/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/apm/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/infra/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/investigate_app/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/observability/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/observability_logs_explorer/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/observability_shared/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/slo/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/synthetics/tsconfig.type_check.json\r\n./x-pack/plugins/observability_solution/uptime/tsconfig.type_check.json\r\n./x-pack/plugins/rule_registry/tsconfig.type_check.json\r\n./x-pack/plugins/stack_alerts/tsconfig.type_check.json\r\n./x-pack/plugins/transform/tsconfig.type_check.json\r\n./x-pack/plugins/triggers_actions_ui/tsconfig.type_check.json\r\n./x-pack/solutions/security/plugins/timelines/tsconfig.type_check.json\r\n./x-pack/test/alerting_api_integration/common/plugins/alerts/tsconfig.type_check.json\r\n./x-pack/test/security_solution_api_integration/tsconfig.type_check.json\r\n./x-pack/test/tsconfig.type_check.json\r\n./x-pack/test_serverless/tsconfig.type_check.json\r\n./yarn.lock\r\n.github/CODEOWNERS\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nsrc/platform/packages/shared/kbn-rule-data-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-rule-data-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-rule-data-utils/tsconfig.type_check.json:2\r\n```\r\n\r\n</details>\r\n\r\nCo-authored-by:
Marshall Main
<55718608+marshallmain@users.noreply.github.com>","sha":"e6a07e63829e116c8e809a3923b7b0fe239e1318"}}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
…rity-detections-response` (elastic#202847)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow
the steps describe
[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).

#### 1 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/rule-data-utils` |
`src/platform/packages/shared/kbn-rule-data-utils` |


<details >
<summary>Updated references</summary>

```
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/shared/kbn-rule-data-utils/jest.config.js
./src/platform/plugins/shared/discover/tsconfig.type_check.json
./tsconfig.base.json
./tsconfig.base.type_check.json
./tsconfig.refs.json
./x-pack/examples/triggers_actions_ui_example/tsconfig.type_check.json
./x-pack/packages/observability/alert_details/tsconfig.type_check.json
./x-pack/packages/observability/alerting_test_data/tsconfig.type_check.json
./x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json
./x-pack/plugins/alerting/tsconfig.type_check.json
./x-pack/plugins/cases/tsconfig.type_check.json
./x-pack/plugins/ml/tsconfig.type_check.json
./x-pack/plugins/observability_solution/apm/tsconfig.type_check.json
./x-pack/plugins/observability_solution/infra/tsconfig.type_check.json
./x-pack/plugins/observability_solution/investigate_app/tsconfig.type_check.json
./x-pack/plugins/observability_solution/observability/tsconfig.type_check.json
./x-pack/plugins/observability_solution/observability_logs_explorer/tsconfig.type_check.json
./x-pack/plugins/observability_solution/observability_shared/tsconfig.type_check.json
./x-pack/plugins/observability_solution/slo/tsconfig.type_check.json
./x-pack/plugins/observability_solution/synthetics/tsconfig.type_check.json
./x-pack/plugins/observability_solution/uptime/tsconfig.type_check.json
./x-pack/plugins/rule_registry/tsconfig.type_check.json
./x-pack/plugins/stack_alerts/tsconfig.type_check.json
./x-pack/plugins/transform/tsconfig.type_check.json
./x-pack/plugins/triggers_actions_ui/tsconfig.type_check.json
./x-pack/solutions/security/plugins/timelines/tsconfig.type_check.json
./x-pack/test/alerting_api_integration/common/plugins/alerts/tsconfig.type_check.json
./x-pack/test/security_solution_api_integration/tsconfig.type_check.json
./x-pack/test/tsconfig.type_check.json
./x-pack/test_serverless/tsconfig.type_check.json
./yarn.lock
.github/CODEOWNERS
```

</details><details >
<summary>Updated relative paths</summary>

```
src/platform/packages/shared/kbn-rule-data-utils/jest.config.js:12
src/platform/packages/shared/kbn-rule-data-utils/tsconfig.json:2
src/platform/packages/shared/kbn-rule-data-utils/tsconfig.type_check.json:2
```

</details>

Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) plugin groups Relocate all plugins and packages under their respective platform/solution groups release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants