Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Remove feature flag entityAlertPreviewDisabled #203171

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

christineweng
Copy link
Contributor

@christineweng christineweng commented Dec 5, 2024

Summary

This PR removes the feature flag entityAlertPreviewDisabled and cleaned up related unit tests.

Checklist

@christineweng christineweng added backport release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team v8.18.0 labels Dec 5, 2024
@christineweng christineweng added this to the 8.18 milestone Dec 5, 2024
@christineweng christineweng self-assigned this Dec 5, 2024
@christineweng christineweng marked this pull request as ready for review December 9, 2024 20:27
@christineweng christineweng requested review from a team as code owners December 9, 2024 20:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup, code LGTM and desk tested everything looks good!

Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@christineweng christineweng merged commit ff64557 into elastic:main Dec 17, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12382397260

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #3 / Fleet preconfigured outputs Preconfigured outputs With a preconfigured monitoring output Should create a default output and the default preconfigured output

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 14.8MB 22.2MB ⚠️ +7.4MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 88.0KB 88.0KB -29.0B
Unknown metric groups

async chunk count

id before after diff
securitySolution 106 107 +1

History

cc @christineweng

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 17, 2024
…lastic#203171)

## Summary

This PR removes the feature flag `entityAlertPreviewDisabled` and
cleaned up related unit tests.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit ff64557)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 18, 2024
…wDisabled` (#203171) (#204664)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Remove feature flag
`entityAlertPreviewDisabled`
(#203171)](#203171)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-17T22:17:50Z","message":"[Security
Solution] Remove feature flag `entityAlertPreviewDisabled`
(#203171)\n\n## Summary\r\n\r\nThis PR removes the feature flag
`entityAlertPreviewDisabled` and\r\ncleaned up related unit
tests.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ff64557c8f51cd2da2429649024b0f2db75683ed","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat
Hunting","Team:Threat
Hunting:Investigations","v8.18.0"],"title":"[Security Solution] Remove
feature flag
`entityAlertPreviewDisabled`","number":203171,"url":"https://github.com/elastic/kibana/pull/203171","mergeCommit":{"message":"[Security
Solution] Remove feature flag `entityAlertPreviewDisabled`
(#203171)\n\n## Summary\r\n\r\nThis PR removes the feature flag
`entityAlertPreviewDisabled` and\r\ncleaned up related unit
tests.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ff64557c8f51cd2da2429649024b0f2db75683ed"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203171","number":203171,"mergeCommit":{"message":"[Security
Solution] Remove feature flag `entityAlertPreviewDisabled`
(#203171)\n\n## Summary\r\n\r\nThis PR removes the feature flag
`entityAlertPreviewDisabled` and\r\ncleaned up related unit
tests.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ff64557c8f51cd2da2429649024b0f2db75683ed"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
…lastic#203171)

## Summary

This PR removes the feature flag `entityAlertPreviewDisabled` and
cleaned up related unit tests.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants