-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Remove feature flag entityAlertPreviewDisabled
#203171
Conversation
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the cleanup, code LGTM and desk tested everything looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
dcff508
to
8ab6019
Compare
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|
…lastic#203171) ## Summary This PR removes the feature flag `entityAlertPreviewDisabled` and cleaned up related unit tests. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit ff64557)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…wDisabled` (#203171) (#204664) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Remove feature flag `entityAlertPreviewDisabled` (#203171)](#203171) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-17T22:17:50Z","message":"[Security Solution] Remove feature flag `entityAlertPreviewDisabled` (#203171)\n\n## Summary\r\n\r\nThis PR removes the feature flag `entityAlertPreviewDisabled` and\r\ncleaned up related unit tests.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff64557c8f51cd2da2429649024b0f2db75683ed","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","v8.18.0"],"title":"[Security Solution] Remove feature flag `entityAlertPreviewDisabled`","number":203171,"url":"https://github.com/elastic/kibana/pull/203171","mergeCommit":{"message":"[Security Solution] Remove feature flag `entityAlertPreviewDisabled` (#203171)\n\n## Summary\r\n\r\nThis PR removes the feature flag `entityAlertPreviewDisabled` and\r\ncleaned up related unit tests.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff64557c8f51cd2da2429649024b0f2db75683ed"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203171","number":203171,"mergeCommit":{"message":"[Security Solution] Remove feature flag `entityAlertPreviewDisabled` (#203171)\n\n## Summary\r\n\r\nThis PR removes the feature flag `entityAlertPreviewDisabled` and\r\ncleaned up related unit tests.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff64557c8f51cd2da2429649024b0f2db75683ed"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
…lastic#203171) ## Summary This PR removes the feature flag `entityAlertPreviewDisabled` and cleaned up related unit tests. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Summary
This PR removes the feature flag
entityAlertPreviewDisabled
and cleaned up related unit tests.Checklist