Align native box connector configs #203241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanstory
added
release_note:fix
backport:prev-major
seanstory
force-pushed
the
seanstory/align-native-box-connector-settings
branch
from
9373b0e to
295bfcb
Compare
|
Starting backport for target branches: 8.16, 8.17, 8.x |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 18, 2024
## Summary Raised in [this community slack post](https://elasticstack.slack.com/archives/C06U8G8NJBY/p1733445905372799?thread_ts=1733378189.186729&cid=C06U8G8NJBY), the Native Connector definition from Kibana was using some config fields (`app_key`, `app_secret`) that didn't align with what the connector itself expects (`client_id`, `client_secret`). There were also a number of configurations defined here that are not used by the Box connector (`use_document_level_security`, `include_inherited_users_and_groups`, `use_text_extraction_service`, `retry_count`, `path`) This change moves to align this definition with the source of truth in the connectors codebase: https://github.com/elastic/connectors/blob/38c2fdbfe71330d6e95de33a30bf114c29ae4cae/connectors/sources/box.py#L263-L311 T ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) (cherry picked from commit db56f01)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 18, 2024
## Summary Raised in [this community slack post](https://elasticstack.slack.com/archives/C06U8G8NJBY/p1733445905372799?thread_ts=1733378189.186729&cid=C06U8G8NJBY), the Native Connector definition from Kibana was using some config fields (`app_key`, `app_secret`) that didn't align with what the connector itself expects (`client_id`, `client_secret`). There were also a number of configurations defined here that are not used by the Box connector (`use_document_level_security`, `include_inherited_users_and_groups`, `use_text_extraction_service`, `retry_count`, `path`) This change moves to align this definition with the source of truth in the connectors codebase: https://github.com/elastic/connectors/blob/38c2fdbfe71330d6e95de33a30bf114c29ae4cae/connectors/sources/box.py#L263-L311 T ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) (cherry picked from commit db56f01)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 18, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [Align native box connector configs (#203241)](#203241) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sean Story","email":"sean.j.story@gmail.com"},"sourceCommit":{"committedDate":"2024-12-18T21:38:45Z","message":"Align native box connector configs (#203241)\n\n## Summary\r\n\r\nRaised in [this community slack\r\npost](https://elasticstack.slack.com/archives/C06U8G8NJBY/p1733445905372799?thread_ts=1733378189.186729&cid=C06U8G8NJBY),\r\nthe Native Connector definition from Kibana was using some config fields\r\n(`app_key`, `app_secret`) that didn't align with what the connector\r\nitself expects (`client_id`, `client_secret`). There were also a number\r\nof configurations defined here that are not used by the Box connector\r\n(`use_document_level_security`, `include_inherited_users_and_groups`,\r\n`use_text_extraction_service`, `retry_count`, `path`)\r\n\r\n\r\nThis change moves to align this definition with the source of truth in\r\nthe connectors codebase:\r\nhttps://github.com/elastic/connectors/blob/38c2fdbfe71330d6e95de33a30bf114c29ae4cae/connectors/sources/box.py#L263-L311\r\n\r\nT\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"db56f019001ae98bc251798f1d8ab1e5511e8bb4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:EnterpriseSearch","backport:prev-major"],"title":"Align native box connector configs","number":203241,"url":"https://github.com/elastic/kibana/pull/203241","mergeCommit":{"message":"Align native box connector configs (#203241)\n\n## Summary\r\n\r\nRaised in [this community slack\r\npost](https://elasticstack.slack.com/archives/C06U8G8NJBY/p1733445905372799?thread_ts=1733378189.186729&cid=C06U8G8NJBY),\r\nthe Native Connector definition from Kibana was using some config fields\r\n(`app_key`, `app_secret`) that didn't align with what the connector\r\nitself expects (`client_id`, `client_secret`). There were also a number\r\nof configurations defined here that are not used by the Box connector\r\n(`use_document_level_security`, `include_inherited_users_and_groups`,\r\n`use_text_extraction_service`, `retry_count`, `path`)\r\n\r\n\r\nThis change moves to align this definition with the source of truth in\r\nthe connectors codebase:\r\nhttps://github.com/elastic/connectors/blob/38c2fdbfe71330d6e95de33a30bf114c29ae4cae/connectors/sources/box.py#L263-L311\r\n\r\nT\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"db56f019001ae98bc251798f1d8ab1e5511e8bb4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203241","number":203241,"mergeCommit":{"message":"Align native box connector configs (#203241)\n\n## Summary\r\n\r\nRaised in [this community slack\r\npost](https://elasticstack.slack.com/archives/C06U8G8NJBY/p1733445905372799?thread_ts=1733378189.186729&cid=C06U8G8NJBY),\r\nthe Native Connector definition from Kibana was using some config fields\r\n(`app_key`, `app_secret`) that didn't align with what the connector\r\nitself expects (`client_id`, `client_secret`). There were also a number\r\nof configurations defined here that are not used by the Box connector\r\n(`use_document_level_security`, `include_inherited_users_and_groups`,\r\n`use_text_extraction_service`, `retry_count`, `path`)\r\n\r\n\r\nThis change moves to align this definition with the source of truth in\r\nthe connectors codebase:\r\nhttps://github.com/elastic/connectors/blob/38c2fdbfe71330d6e95de33a30bf114c29ae4cae/connectors/sources/box.py#L263-L311\r\n\r\nT\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"db56f019001ae98bc251798f1d8ab1e5511e8bb4"}}]}] BACKPORT--> Co-authored-by: Sean Story <sean.j.story@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Dec 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Align native box connector configs (#203241)](#203241) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sean Story","email":"sean.j.story@gmail.com"},"sourceCommit":{"committedDate":"2024-12-18T21:38:45Z","message":"Align native box connector configs (#203241)\n\n## Summary\r\n\r\nRaised in [this community slack\r\npost](https://elasticstack.slack.com/archives/C06U8G8NJBY/p1733445905372799?thread_ts=1733378189.186729&cid=C06U8G8NJBY),\r\nthe Native Connector definition from Kibana was using some config fields\r\n(`app_key`, `app_secret`) that didn't align with what the connector\r\nitself expects (`client_id`, `client_secret`). There were also a number\r\nof configurations defined here that are not used by the Box connector\r\n(`use_document_level_security`, `include_inherited_users_and_groups`,\r\n`use_text_extraction_service`, `retry_count`, `path`)\r\n\r\n\r\nThis change moves to align this definition with the source of truth in\r\nthe connectors codebase:\r\nhttps://github.com/elastic/connectors/blob/38c2fdbfe71330d6e95de33a30bf114c29ae4cae/connectors/sources/box.py#L263-L311\r\n\r\nT\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"db56f019001ae98bc251798f1d8ab1e5511e8bb4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:EnterpriseSearch","backport:prev-major"],"title":"Align native box connector configs","number":203241,"url":"https://github.com/elastic/kibana/pull/203241","mergeCommit":{"message":"Align native box connector configs (#203241)\n\n## Summary\r\n\r\nRaised in [this community slack\r\npost](https://elasticstack.slack.com/archives/C06U8G8NJBY/p1733445905372799?thread_ts=1733378189.186729&cid=C06U8G8NJBY),\r\nthe Native Connector definition from Kibana was using some config fields\r\n(`app_key`, `app_secret`) that didn't align with what the connector\r\nitself expects (`client_id`, `client_secret`). There were also a number\r\nof configurations defined here that are not used by the Box connector\r\n(`use_document_level_security`, `include_inherited_users_and_groups`,\r\n`use_text_extraction_service`, `retry_count`, `path`)\r\n\r\n\r\nThis change moves to align this definition with the source of truth in\r\nthe connectors codebase:\r\nhttps://github.com/elastic/connectors/blob/38c2fdbfe71330d6e95de33a30bf114c29ae4cae/connectors/sources/box.py#L263-L311\r\n\r\nT\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"db56f019001ae98bc251798f1d8ab1e5511e8bb4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203241","number":203241,"mergeCommit":{"message":"Align native box connector configs (#203241)\n\n## Summary\r\n\r\nRaised in [this community slack\r\npost](https://elasticstack.slack.com/archives/C06U8G8NJBY/p1733445905372799?thread_ts=1733378189.186729&cid=C06U8G8NJBY),\r\nthe Native Connector definition from Kibana was using some config fields\r\n(`app_key`, `app_secret`) that didn't align with what the connector\r\nitself expects (`client_id`, `client_secret`). There were also a number\r\nof configurations defined here that are not used by the Box connector\r\n(`use_document_level_security`, `include_inherited_users_and_groups`,\r\n`use_text_extraction_service`, `retry_count`, `path`)\r\n\r\n\r\nThis change moves to align this definition with the source of truth in\r\nthe connectors codebase:\r\nhttps://github.com/elastic/connectors/blob/38c2fdbfe71330d6e95de33a30bf114c29ae4cae/connectors/sources/box.py#L263-L311\r\n\r\nT\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"db56f019001ae98bc251798f1d8ab1e5511e8bb4"}}]}] BACKPORT--> Co-authored-by: Sean Story <sean.j.story@gmail.com>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
## Summary Raised in [this community slack post](https://elasticstack.slack.com/archives/C06U8G8NJBY/p1733445905372799?thread_ts=1733378189.186729&cid=C06U8G8NJBY), the Native Connector definition from Kibana was using some config fields (`app_key`, `app_secret`) that didn't align with what the connector itself expects (`client_id`, `client_secret`). There were also a number of configurations defined here that are not used by the Box connector (`use_document_level_security`, `include_inherited_users_and_groups`, `use_text_extraction_service`, `retry_count`, `path`) This change moves to align this definition with the source of truth in the connectors codebase: https://github.com/elastic/connectors/blob/38c2fdbfe71330d6e95de33a30bf114c29ae4cae/connectors/sources/box.py#L263-L311 T ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Raised in this community slack post, the Native Connector definition from Kibana was using some config fields (
app_key,app_secret) that didn't align with what the connector itself expects (client_id,client_secret). There were also a number of configurations defined here that are not used by the Box connector (use_document_level_security,include_inherited_users_and_groups,use_text_extraction_service,retry_count,path)This change moves to align this definition with the source of truth in the connectors codebase: https://github.com/elastic/connectors/blob/38c2fdbfe71330d6e95de33a30bf114c29ae4cae/connectors/sources/box.py#L263-L311
T
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.