Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [embeddable] remove EmbeddableRenderer and embeddable stories (#203007) #203655

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[8.x] [embeddable] remove EmbeddableRenderer and embeddable stories (#203007) #203655

merged 1 commit into from
Dec 10, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@nreese
[embeddable] remove EmbeddableRenderer and embeddable stories (elasti…
ee3f968 
…c#203007)

PR starts cleaning up legacy embeddable components by removing
EmbeddableRenderer, EmbedddableRoot, and embeddable story books.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
(cherry picked from commit 80f915f)
@kibanamachine kibanamachine enabled auto-merge (squash) December 10, 2024 17:43
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 10, 2024
@kibanamachine kibanamachine mentioned this pull request Dec 10, 2024
Merged
@kibanamachine kibanamachine merged commit eb403d3 into elastic:8.x Dec 10, 2024
14 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 143 141 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 462 458 -4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 72.7KB 70.5KB -2.2KB
Unknown metric groups

API count

id before after diff
embeddable 571 564 -7

ESLint disabled line counts

id before after diff
embeddable 6 3 -3

Total ESLint disabled count

id before after diff
embeddable 8 5 -3

cc @nreese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@nreese nreese

Labels
backport Feature:Embedding Embedding content via iFrame
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @nreese