[8.x] [UA] Remove 7->8 multitype check (#203995) #204038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary
Removes the 7->8.x logic for detecting and warning users about custom
types. Specifically, we had a `GET index` call with `include_type_name`
that is no longer supported and would return mappings in the following,
deprecated, multitype form:
```jsonc
{
"mappings": {
"<type_name>": { "properties": { /* properties */ } }
}
}
```
Now you can only get:
```jsonc
{
"mappings": {
"properties": { /* properties */ }
}
```
...including `include_type_name` is causing a 400 response from ES,
blocking UA's ability to reindex. Existing code already handles both of
these forms bc it had to for 7.last, this PR just removes logic
targeting the former (and removes our outdated user-facing warning).
## Resources
* 7->8 removal notice
https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html
* old docs
https://www.elastic.co/guide/en/elasticsearch/reference/6.8/indices-get-index.html
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b525d00)
# Conflicts:
# .github/CODEOWNERS
# x-pack/plugins/upgrade_assistant/server/lib/reindexing/index_settings.ts
# x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts
Bamieh
approved these changes
Dec 12, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation