[CI] Remove unwanted console.log from pipeline.ts #204724
Open
+31
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
delanni
force-pushed
the
fix-ci-pipeline-renovate
branch
from
1491e98 to
1cb56fd
Compare
delanni
force-pushed
the
fix-ci-pipeline-renovate
branch
from
1cb56fd to
961499a
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
Ikuni17
reviewed
Dec 18, 2024
| */ | ||
|
|
||
| export function emitPipeline(pipelineStr: string) { | ||
| console.log(pipelineStr); |
There was a problem hiding this comment.
Can we convert to Set to remove duplicates here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Logging to stdout from this file would result uploading the logged string to buildkite as a pipeline definition, causing errors (https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4).
Also, adds an inline eslint rule to warn about
console.log/stdoutusage, as this has happened before by oversight.Overlaps with: #204672