[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules #204823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
added
test
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
xcrzx
approved these changes
Dec 19, 2024
...n/test_suites/detections_response/utils/rules/prebuilt_rules/install_fleet_package_by_url.ts
Outdated
Show resolved
Hide resolved
banderror
force-pushed
the
fix-retry-timeout-for-installPrebuiltRulesFleetPackage
branch
from
2ebcb66 to
f11efc9
Compare
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
banderror
force-pushed
the
fix-retry-timeout-for-installPrebuiltRulesFleetPackage
branch
from
742e8be to
8e3bf33
Compare
|
Starting backport for target branches: 8.16, 8.17, 8.x |
💚 Build Succeeded
Metrics [docs]
History
cc @banderror |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 20, 2024
…t package with prebuilt rules (elastic#204823) **Fixes: elastic#204812 ## Summary This PR increases the total timeout for installing the prebuilt rules package from the API integration tests from 2 minutes to 6 minutes, where 6 minutes = 2 minutes * 3 attempts. Logic before the fix: - If the first attempt takes more than 2 minutes, it will continue to run. - If the first attempt takes less than 2 minutes, there will be a second one. - If the first attempt takes more than 2 minutes, there won't be a second one. Logic after the fix: - If the first attempt takes more than 2 minutes, it will continue to run. - If the first attempt takes less than 2 minutes, there will be a second one. - If the first attempt takes more than 2 minutes but less than 6, there will be a second one. - If the first attempt takes more than 6 minutes, there won't be a second one. Context: elastic#204812 (comment) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit 39091fc)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 20, 2024
…t package with prebuilt rules (elastic#204823) **Fixes: elastic#204812 ## Summary This PR increases the total timeout for installing the prebuilt rules package from the API integration tests from 2 minutes to 6 minutes, where 6 minutes = 2 minutes * 3 attempts. Logic before the fix: - If the first attempt takes more than 2 minutes, it will continue to run. - If the first attempt takes less than 2 minutes, there will be a second one. - If the first attempt takes more than 2 minutes, there won't be a second one. Logic after the fix: - If the first attempt takes more than 2 minutes, it will continue to run. - If the first attempt takes less than 2 minutes, there will be a second one. - If the first attempt takes more than 2 minutes but less than 6, there will be a second one. - If the first attempt takes more than 6 minutes, there won't be a second one. Context: elastic#204812 (comment) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit 39091fc)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 20, 2024
…t package with prebuilt rules (elastic#204823) **Fixes: elastic#204812 ## Summary This PR increases the total timeout for installing the prebuilt rules package from the API integration tests from 2 minutes to 6 minutes, where 6 minutes = 2 minutes * 3 attempts. Logic before the fix: - If the first attempt takes more than 2 minutes, it will continue to run. - If the first attempt takes less than 2 minutes, there will be a second one. - If the first attempt takes more than 2 minutes, there won't be a second one. Logic after the fix: - If the first attempt takes more than 2 minutes, it will continue to run. - If the first attempt takes less than 2 minutes, there will be a second one. - If the first attempt takes more than 2 minutes but less than 6, there will be a second one. - If the first attempt takes more than 6 minutes, there won't be a second one. Context: elastic#204812 (comment) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit 39091fc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 20, 2024
…ng Fleet package with prebuilt rules (#204823) (#205047) # Backport This will backport the following commits from `main` to `8.17`: - [[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)](#204823) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgii Gorbachev","email":"georgii.gorbachev@elastic.co"},"sourceCommit":{"committedDate":"2024-12-20T14:07:17Z","message":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)\n\n**Fixes: https://github.com/elastic/kibana/issues/204812**\r\n\r\n## Summary\r\n\r\nThis PR increases the total timeout for installing the prebuilt rules\r\npackage from the API integration tests from 2 minutes to 6 minutes,\r\nwhere 6 minutes = 2 minutes * 3 attempts.\r\n\r\nLogic before the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes, there won't be a\r\nsecond one.\r\n\r\nLogic after the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes but less than 6, there\r\nwill be a second one.\r\n- If the first attempt takes more than 6 minutes, there won't be a\r\nsecond one.\r\n\r\nContext:\r\nhttps://github.com//issues/204812#issuecomment-2552010657\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"39091fc30ba274f155cb807ef5de4e98bcc1072f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v8.16.3","v8.17.1"],"title":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules","number":204823,"url":"https://github.com/elastic/kibana/pull/204823","mergeCommit":{"message":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)\n\n**Fixes: https://github.com/elastic/kibana/issues/204812**\r\n\r\n## Summary\r\n\r\nThis PR increases the total timeout for installing the prebuilt rules\r\npackage from the API integration tests from 2 minutes to 6 minutes,\r\nwhere 6 minutes = 2 minutes * 3 attempts.\r\n\r\nLogic before the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes, there won't be a\r\nsecond one.\r\n\r\nLogic after the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes but less than 6, there\r\nwill be a second one.\r\n- If the first attempt takes more than 6 minutes, there won't be a\r\nsecond one.\r\n\r\nContext:\r\nhttps://github.com//issues/204812#issuecomment-2552010657\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"39091fc30ba274f155cb807ef5de4e98bcc1072f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204823","number":204823,"mergeCommit":{"message":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)\n\n**Fixes: https://github.com/elastic/kibana/issues/204812**\r\n\r\n## Summary\r\n\r\nThis PR increases the total timeout for installing the prebuilt rules\r\npackage from the API integration tests from 2 minutes to 6 minutes,\r\nwhere 6 minutes = 2 minutes * 3 attempts.\r\n\r\nLogic before the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes, there won't be a\r\nsecond one.\r\n\r\nLogic after the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes but less than 6, there\r\nwill be a second one.\r\n- If the first attempt takes more than 6 minutes, there won't be a\r\nsecond one.\r\n\r\nContext:\r\nhttps://github.com//issues/204812#issuecomment-2552010657\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"39091fc30ba274f155cb807ef5de4e98bcc1072f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Dec 20, 2024
…g Fleet package with prebuilt rules (#204823) (#205048) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)](#204823) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgii Gorbachev","email":"georgii.gorbachev@elastic.co"},"sourceCommit":{"committedDate":"2024-12-20T14:07:17Z","message":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)\n\n**Fixes: https://github.com/elastic/kibana/issues/204812**\r\n\r\n## Summary\r\n\r\nThis PR increases the total timeout for installing the prebuilt rules\r\npackage from the API integration tests from 2 minutes to 6 minutes,\r\nwhere 6 minutes = 2 minutes * 3 attempts.\r\n\r\nLogic before the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes, there won't be a\r\nsecond one.\r\n\r\nLogic after the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes but less than 6, there\r\nwill be a second one.\r\n- If the first attempt takes more than 6 minutes, there won't be a\r\nsecond one.\r\n\r\nContext:\r\nhttps://github.com//issues/204812#issuecomment-2552010657\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"39091fc30ba274f155cb807ef5de4e98bcc1072f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v8.16.3","v8.17.1"],"title":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules","number":204823,"url":"https://github.com/elastic/kibana/pull/204823","mergeCommit":{"message":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)\n\n**Fixes: https://github.com/elastic/kibana/issues/204812**\r\n\r\n## Summary\r\n\r\nThis PR increases the total timeout for installing the prebuilt rules\r\npackage from the API integration tests from 2 minutes to 6 minutes,\r\nwhere 6 minutes = 2 minutes * 3 attempts.\r\n\r\nLogic before the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes, there won't be a\r\nsecond one.\r\n\r\nLogic after the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes but less than 6, there\r\nwill be a second one.\r\n- If the first attempt takes more than 6 minutes, there won't be a\r\nsecond one.\r\n\r\nContext:\r\nhttps://github.com//issues/204812#issuecomment-2552010657\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"39091fc30ba274f155cb807ef5de4e98bcc1072f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204823","number":204823,"mergeCommit":{"message":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)\n\n**Fixes: https://github.com/elastic/kibana/issues/204812**\r\n\r\n## Summary\r\n\r\nThis PR increases the total timeout for installing the prebuilt rules\r\npackage from the API integration tests from 2 minutes to 6 minutes,\r\nwhere 6 minutes = 2 minutes * 3 attempts.\r\n\r\nLogic before the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes, there won't be a\r\nsecond one.\r\n\r\nLogic after the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes but less than 6, there\r\nwill be a second one.\r\n- If the first attempt takes more than 6 minutes, there won't be a\r\nsecond one.\r\n\r\nContext:\r\nhttps://github.com//issues/204812#issuecomment-2552010657\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"39091fc30ba274f155cb807ef5de4e98bcc1072f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Dec 20, 2024
…ng Fleet package with prebuilt rules (#204823) (#205046) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)](#204823) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgii Gorbachev","email":"georgii.gorbachev@elastic.co"},"sourceCommit":{"committedDate":"2024-12-20T14:07:17Z","message":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)\n\n**Fixes: https://github.com/elastic/kibana/issues/204812**\r\n\r\n## Summary\r\n\r\nThis PR increases the total timeout for installing the prebuilt rules\r\npackage from the API integration tests from 2 minutes to 6 minutes,\r\nwhere 6 minutes = 2 minutes * 3 attempts.\r\n\r\nLogic before the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes, there won't be a\r\nsecond one.\r\n\r\nLogic after the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes but less than 6, there\r\nwill be a second one.\r\n- If the first attempt takes more than 6 minutes, there won't be a\r\nsecond one.\r\n\r\nContext:\r\nhttps://github.com//issues/204812#issuecomment-2552010657\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"39091fc30ba274f155cb807ef5de4e98bcc1072f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v8.16.3","v8.17.1"],"title":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules","number":204823,"url":"https://github.com/elastic/kibana/pull/204823","mergeCommit":{"message":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)\n\n**Fixes: https://github.com/elastic/kibana/issues/204812**\r\n\r\n## Summary\r\n\r\nThis PR increases the total timeout for installing the prebuilt rules\r\npackage from the API integration tests from 2 minutes to 6 minutes,\r\nwhere 6 minutes = 2 minutes * 3 attempts.\r\n\r\nLogic before the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes, there won't be a\r\nsecond one.\r\n\r\nLogic after the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes but less than 6, there\r\nwill be a second one.\r\n- If the first attempt takes more than 6 minutes, there won't be a\r\nsecond one.\r\n\r\nContext:\r\nhttps://github.com//issues/204812#issuecomment-2552010657\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"39091fc30ba274f155cb807ef5de4e98bcc1072f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204823","number":204823,"mergeCommit":{"message":"[Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823)\n\n**Fixes: https://github.com/elastic/kibana/issues/204812**\r\n\r\n## Summary\r\n\r\nThis PR increases the total timeout for installing the prebuilt rules\r\npackage from the API integration tests from 2 minutes to 6 minutes,\r\nwhere 6 minutes = 2 minutes * 3 attempts.\r\n\r\nLogic before the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes, there won't be a\r\nsecond one.\r\n\r\nLogic after the fix:\r\n- If the first attempt takes more than 2 minutes, it will continue to\r\nrun.\r\n- If the first attempt takes less than 2 minutes, there will be a second\r\none.\r\n- If the first attempt takes more than 2 minutes but less than 6, there\r\nwill be a second one.\r\n- If the first attempt takes more than 6 minutes, there won't be a\r\nsecond one.\r\n\r\nContext:\r\nhttps://github.com//issues/204812#issuecomment-2552010657\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"39091fc30ba274f155cb807ef5de4e98bcc1072f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
banderror
deleted the
fix-retry-timeout-for-installPrebuiltRulesFleetPackage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #204812
Summary
This PR increases the total timeout for installing the prebuilt rules package from the API integration tests from 2 minutes to 6 minutes, where 6 minutes = 2 minutes * 3 attempts.
Logic before the fix:
Logic after the fix:
Context: #204812 (comment)
Checklist