Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Fix reporting for non-default spaces #62226

Merged
merged 6 commits into from
Apr 4, 2020
Merged

[Reporting] Fix reporting for non-default spaces #62226

merged 6 commits into from
Apr 4, 2020

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Apr 1, 2020 •
edited
Loading

Summary

Closes #61813

Checklist

Test cases:
Generate a report from a button, and from sending a request to the copied POST URL

  • PNG/PDF from Dashboard in default space and without server.basePath
  • PNG/PDF from Dashboard out of default space and without server.basePath
  • PNG/PDF from Dashboard in default space and with server.basePath
  • PNG/PDF from Dashboard out of default space and with server.basePath
  • PDF from Canvas in default space and without server.basePath
  • PDF from Canvas out of default space and without server.basePath
  • PDF from Canvas in default space and with server.basePath
  • PDF from Canvas out of default space and with server.basePath

Delete any items that are not applicable to this PR.

For maintainers

@tsullivan tsullivan requested a review from a team as a code owner April 1, 2020 19:53
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8 v7.8.0 v8.0.0 and removed v7.8 labels Apr 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan tsullivan changed the title Reporting/fix job urls Fix reporting for non-default spaces Apr 1, 2020
@tsullivan tsullivan requested review from a team and flash1293 April 1, 2020 20:43
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan tsullivan changed the title Fix reporting for non-default spaces [Reporting] Fix reporting for non-default spaces Apr 1, 2020
flash1293
flash1293 approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in chrome and works as expected, created png/pdf/print-optimized pdf reports of a dashboard in a custom space and all were created successfully. LGTM 👍

Did not do a thorough code review.

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

poffdeluxe
poffdeluxe approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas changes look good

joelgriffith
joelgriffith approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@joelgriffith joelgriffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsullivan tsullivan merged commit a5c3865 into elastic:master Apr 4, 2020
@tsullivan tsullivan deleted the reporting/fix-job-urls branch April 4, 2020 03:18
This was referenced Apr 4, 2020
Merged
Merged
tsullivan added a commit to tsullivan/kibana that referenced this pull request Apr 4, 2020
@tsullivan @elasticmachine
[Reporting] Fix reporting for non-default spaces (elastic#62226)
a3d41cc 
* [Reporting] Fix URLs in job params when basePath includes namespace suffix

* canvas fix

* cleanup

* update snapshots in tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan added a commit to tsullivan/kibana that referenced this pull request Apr 4, 2020
@tsullivan @elasticmachine
[Reporting] Fix reporting for non-default spaces (elastic#62226)
a133f58 
* [Reporting] Fix URLs in job params when basePath includes namespace suffix

* canvas fix

* cleanup

* update snapshots in tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan added a commit that referenced this pull request Apr 4, 2020
@tsullivan @elasticmachine
[Reporting] Fix reporting for non-default spaces (#62226) (#62538)
e979b14 
* [Reporting] Fix URLs in job params when basePath includes namespace suffix

* canvas fix

* cleanup

* update snapshots in tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan added a commit that referenced this pull request Apr 5, 2020
@tsullivan @elasticmachine
[Reporting] Fix reporting for non-default spaces (#62226) (#62539)
6b36427 
* [Reporting] Fix URLs in job params when basePath includes namespace suffix

* canvas fix

* cleanup

* update snapshots in tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 6, 2020
@gmmorris
Merge branch 'event-log/query-support' of github.com:gmmorris/kibana …
503bea6 
…into event-log/query-support

* 'event-log/query-support' of github.com:gmmorris/kibana: (41 commits)
  [jenkins] refer to sizes in most pipeline code (elastic#62082)
  skip flaky suite (elastic#60470)
  [Discover] Fix flaky FT in field visualize (elastic#62418)
  [ML] Data Frame Analytics: Fix feature importance (elastic#61761)
  [Reporting] Use a shim for server config (elastic#62086)
  [Reporting] Fix reporting for non-default spaces (elastic#62226)
  Fix bug that coerced empty scaled float value to 0 (elastic#62251)
  [SIEM] [Detection Engine] Remove has manage api keys requireme… (elastic#62446)
  [Maps] Safely handle empty string and invalid strings from EuiColorPicker (elastic#62507)
  Reporting/bug more blacklisted headers (elastic#62389)
  [SIEM] Prevent undefined behavior in our ML popover (elastic#62498)
  [SIEM] [Detection Engine] remove all unknowns from all rules t… (elastic#62327)
  base changes for active/current node styling (elastic#62007)
  [kbn/ui-shared-deps] expand and split (elastic#62364)
  [ML] DF Analytics - ensure destination index pattern created (elastic#62450)
  Mark rule run as failure if there was an error (elastic#62383)
  Add docs for metric explorer alerts (elastic#62314)
  skip flaky suite (elastic#62281)
  [SIEM][Detection Engine] Fixes export of single rule and the icons
  fixes flakiness (elastic#62406)
  ...
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@joelgriffith joelgriffith joelgriffith approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reporting fails for dashboard in non-default space
7 participants
@tsullivan @elasticmachine @kibanamachine @poffdeluxe @joelgriffith @flash1293 @sophiec20