-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Improve TS and update Reporting usage data model #64841
Merged
tsullivan
merged 10 commits into
elastic:master
from
tsullivan:reporting/usage-stricter-ts
May 4, 2020
Merged
[Reporting] Improve TS and update Reporting usage data model #64841
tsullivan
merged 10 commits into
elastic:master
from
tsullivan:reporting/usage-stricter-ts
May 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
Skip the PR/issue when compiling release notes
v7.8.0
v8.0.0
Team:Reporting Services
labels
Apr 29, 2020
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
changed the title
[Reporting] Stricter types for Reporting Usage data
[Reporting] Updates to Reporting Usage data
Apr 30, 2020
tsullivan
changed the title
[Reporting] Updates to Reporting Usage data
[Reporting] Improve typing and update Reporting Usage data model
Apr 30, 2020
tsullivan
changed the title
[Reporting] Improve typing and update Reporting Usage data model
[Reporting] Improve TS and update Reporting usage data model
Apr 30, 2020
joelgriffith
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice typings + tests. Reduce ftw
TinaHeiligers
approved these changes
May 4, 2020
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/saved_objects_management/edit_saved_object·ts.saved objects management saved objects edition page allows to delete a saved objectStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
May 4, 2020
…#64841) * Stricter types for Reporting Usage data * Allow more type inference * remove lastDay filter * update ts and add test * fix tests * fix test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
May 5, 2020
…#65194) * Stricter types for Reporting Usage data * Allow more type inference * remove lastDay filter * update ts and add test * fix tests * fix test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sophiec20
added
the
(Deprecated) Feature:Reporting
Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead
label
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
(Deprecated) Feature:Reporting
Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead
release_note:skip
Skip the PR/issue when compiling release notes
v7.8.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ReportingUsageType
interface to validate the mappings for Reporting data in the telemetry mapping cluster are correct.lastDay
fields from the dataChecklist
For maintainers