-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity Analytics: Requirements and limitations #4162
Conversation
Documentation previews: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks great! I left a few suggestions and questions below. Hopefully they're helpful. 😄
docs/getting-started/ea-req.asciidoc
Outdated
@@ -0,0 +1,37 @@ | |||
[[ea-requirements]] | |||
= Entity Analytics prerequisites | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natasha-moore-elastic following the page title with a section header is a bit jarring. To give users some quick context, it might be useful to write a sentence or two that briefly summarizes this page.
@SourinPaul are we now calling the risk scoring feature "Entity Analytics" in the docs? Also, should this page be included under the Useful links section within the Entity Risk Score page? Linking to multiple doc pages in the UI is a little excessive imo, but I definitely think feature requirements are necessary to highlight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SourinPaul are we now calling the risk scoring feature "Entity Analytics" in the docs? Also, should this page be included under the Useful links section within the Entity Risk Score page? Linking to multiple doc pages in the UI is a little excessive imo, but I definitely think feature requirements are necessary to highlight.
@nastasha-solomon the current UI reference to the feature is incorrect. Here is the bug logged to correct the UI reference #7920. In its correct form, the UI reference will take the user to the (new) Entity Risk Scoring
feature documentation page.
I agree that linking to multiple doc pages (Feature overview, Prerequisites for the feature) in the UI may be excessive, given we expect to improve or evolve the feature quickly.
How about ensuring the Entity Risk Scoring Prerequisites
section is highlighted on the page the user first lands ( section above)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing that issue, @SourinPaul. Good to know that the links are being updated for 8.11! :)
As for linking this page, I do think it should be placed at the top of the list under the Useful links section. I'd use the page title as well, so the linked text is consistent with our docs.
Lastly, it might be a good idea to reference this page wherever these privileges are needed to view risk score data within the Security app. For example, if these privileges are required to turn on and or view risk score in the Entity Analytics dashboard, I would mention it there. I'm not sure what that'd look like, or if there's even time to add it into 8.11, so just something to consider for a future release.
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Thanks for the fast reviews @nastasha-solomon & @SourinPaul! I've applied the suggestions and comments. |
The build has failed because of the reference to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small comments, and one general question: what's the preferred capitalization for this feature? Sometimes it appears title case, other times lowercase. I personally prefer lowercase for most features, but it depends on how Product is positioning and branding this.
Good question! @SourinPaul, is there a preference to capitalize the feature name from the Product side? If not, let's lowercase it, per our capitalization guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add; previous feedback looks good.
* Entity Analytics: Requirements and limitations * Fixes capitalization * Uses attribute * Update docs/getting-started/ea-req.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/getting-started/ea-req.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/getting-started/ea-req.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/getting-started/ea-req.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Applies review comments * Adds reference to Entity Risk Scoring * Updates licensing info * Applies review feedback * Update docs/getting-started/ers-req.asciidoc --------- Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> (cherry picked from commit aad7b27)
* Entity Analytics: Requirements and limitations * Fixes capitalization * Uses attribute * Update docs/getting-started/ea-req.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/getting-started/ea-req.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/getting-started/ea-req.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/getting-started/ea-req.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Applies review comments * Adds reference to Entity Risk Scoring * Updates licensing info * Applies review feedback * Update docs/getting-started/ers-req.asciidoc --------- Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> (cherry picked from commit aad7b27) Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Resolves #4124.
Adds a new page within Elastic Security requirements that outlines user requirements and known limitations of the new risk scoring engine.
Preview: Entity Analytics prerequisites