Add a keepAlive option and enable SO_KEEPALIVE by default
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling `SO_KEEPALIVE` on memcached connections helps prevent idle connections from being closed. This resolves an issue I was experiencing in which I saw multiple `ECONNRESET` errors per hour, causing the client to have to reconnect each time. Keepalive is enabled by default with an initial delay of 1 minute following the last server-sent packet. The delay may be customized by providing a number of milliseconds as the value of the new `keepAlive` client option, or keepalive may be disabled entirely by setting the `keepAlive` option to `false`.
I realized it's not necessary to call `startSingleServer()`, and it _may_ be necessary to shut down the client (although some other tests don't seem to do this). This doesn't actually change anything about test completion time when I run them locally, but maybe it has something to do with why tests seem to hang in GitHub Actions?
Looks like it worked! 🎉 |
|
Looks good to me. |
|
@smuthya Can you please review/merge this PR? |
smuthya
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling
SO_KEEPALIVEon memcached connections helps prevent idle connections from being closed. This resolves an issue I was experiencing in which I saw multipleECONNRESETerrors per hour, causing the client to have to reconnect each time.This change enables
SO_KEEPALIVEby default with an initial delay of 1 minute following the last server-sent packet. The delay may be customized by providing a number of milliseconds as the value of the newkeepAliveclient option, or keepalive may be disabled entirely by setting thekeepAliveoption tofalse.I also took a shot at simplifying the
TCP_NODELAYunit tests I added in PR #20 in hopes of addressing the issue where GitHub Actions never seems to finish running tests, although I still haven't been able to reproduce that behavior locally.