Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong typing of Application.electron on Spectron 13.0.0 #878

Open
sirtimid opened this issue Mar 1, 2021 · 0 comments · May be fixed by #999
Open

Wrong typing of Application.electron on Spectron 13.0.0 #878

sirtimid opened this issue Mar 1, 2021 · 0 comments · May be fixed by #999

Comments

@sirtimid
Copy link

sirtimid commented Mar 1, 2021

Currently the type of Application.electron is Electron.RemoteMainInterface but logging the keys of app.electron it seems that it should be

interface SpectronElectron {
    clipboard: Electron.Clipboard;
    contextBridge: Electron.ContextBridge;
    crashReporter: Electron.CrashReporter;
    desktopCapturer: Electron.DesktopCapturer;
    ipcRenderer: Electron.IpcRenderer;
    nativeImage: Electron.NativeImage;
    shell: Electron.Shell;
    webFrame: Electron.WebFrame;
    remote: Electron.Remote;
  }

I was using ipcRenderer and TS linter complained Property 'ipcRenderer' does not exist on type 'RemoteMainInterface'.

andersk added a commit to andersk/spectron that referenced this issue Jul 8, 2021
andersk added a commit to andersk/spectron that referenced this issue Jul 8, 2021
Fixes electron-userland#878, fixes electron-userland#998.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk added a commit to andersk/spectron that referenced this issue Sep 16, 2021
Fixes electron-userland#878, fixes electron-userland#998.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk added a commit to andersk/spectron that referenced this issue Jan 11, 2022
Fixes electron-userland#878, fixes electron-userland#998.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk added a commit to andersk/spectron that referenced this issue Feb 2, 2022
Fixes electron-userland#878, fixes electron-userland#998.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant