Fix types of wrapped Electron methods to return Promise #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersk
force-pushed
the
promise-types
branch
2 times, most recently
from
d54b176 to
fb20c86
Compare
Merged
|
@andersk Sorry it took so long for someone to see this 🙂 I merged your doc/type PR and I think I can reconcile the conflicts in the main definition file, but let me know if that seems reasonable and we can merge this one as well! |
|
The PR you merged (#897) is not mine. Like I said there, this is a more complete fix. It was was intended to be merged instead of #897, not in addition to #897. However, I’ve now resolved the conflicts so this can be applied on top. |
andersk
force-pushed
the
promise-types
branch
from
fb20c86 to
41b4452
Compare
|
@andersk @VerteDinde Is there any update on this? This would presumably fix an issue I am seeing: |
andersk
force-pushed
the
promise-types
branch
from
41b4452 to
4e937f6
Compare
‘declare module’ is for declaring a third-party module, not for publishing first-party declarations. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Fixes electron-userland#878, fixes electron-userland#998. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
promise-types
branch
from
72bddca to
47d1005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #878, fixes #998.