-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Promise for {electron, browserWindow, webContents} types #998
Comments
andersk
added a commit
to andersk/spectron
that referenced
this issue
Jul 8, 2021
Fixes electron-userland#998. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
added a commit
to andersk/spectron
that referenced
this issue
Jul 8, 2021
Fixes electron-userland#878, electron-userland#998. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
added a commit
to andersk/spectron
that referenced
this issue
Jul 8, 2021
Fixes electron-userland#878, fixes electron-userland#998. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
added a commit
to andersk/spectron
that referenced
this issue
Sep 16, 2021
Fixes electron-userland#878, fixes electron-userland#998. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
added a commit
to andersk/spectron
that referenced
this issue
Jan 11, 2022
Fixes electron-userland#878, fixes electron-userland#998. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
added a commit
to andersk/spectron
that referenced
this issue
Feb 2, 2022
Fixes electron-userland#878, fixes electron-userland#998. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
spectron
TypeScript declarations copy theRemoteMainInterface
,BrowserWindow
,WebContents
types fromelectron
, but this leads to incorrect type errors becausespectron
changes all the methods on these interfaces returnPromise
s.For example, given
TypeScript complains:
The text was updated successfully, but these errors were encountered: