Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cancel download #137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: cancel download #137

wants to merge 3 commits into from

Conversation

adnanlah
Copy link

Hello,

I added a new IPC handler cancel-download to cancel the download completely, because closing the modal only doesn't stop the app from continuing the download in the background.

Thanks everyone for this project.

@RSS1102
Copy link
Member

RSS1102 commented Apr 19, 2023

@adnanlah but, after canceling the update, another attempt to continue the update will result in the following error (without restarting the exe):
Cannot download differentially, fallback to full download: Error: cancelled
I haven't found the reason for this error yet.

@adnanlah
Copy link
Author

Cannot download differentially, fallback to full download: Error: cancelled

True. I have fixed by generating a new CancellationToken after firing cancel(). It works fine for me now.

Thank you very much.

@RSS1102
Copy link
Member

RSS1102 commented Apr 21, 2023

Cannot download differentially, fallback to full download: Error: cancelled

True. I have fixed by generating a new CancellationToken after firing cancel(). It works fine for me now.

Thank you very much.

After I performed the update cancel update-operation-update(repeated multiple timesupdate-operation), he still received an error. (Sorry, I don't quite understand this convenience. I'm not sure if it's due to operational issues. Have you ever had such a problem with your business?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants