knock : close screen when canceling knock

element-hq · Oct 22, 2024 · 512b362 · 512b362
1 parent bc4a9a4
commit 512b362
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/...s/joinroom/impl/src/main/kotlin/io/element/android/features/joinroom/impl/JoinRoomNode.kt b/...s/joinroom/impl/src/main/kotlin/io/element/android/features/joinroom/impl/JoinRoomNode.kt
@@ -43,6 +43,7 @@ class JoinRoomNode @AssistedInject constructor(
             state = state,
             onBackClick = ::navigateUp,
             onJoinSuccess = ::navigateUp,
+            onCancelKnockSuccess = ::navigateUp,
             onKnockSuccess = { },
             modifier = modifier
         )

diff --git a/...s/joinroom/impl/src/main/kotlin/io/element/android/features/joinroom/impl/JoinRoomView.kt b/...s/joinroom/impl/src/main/kotlin/io/element/android/features/joinroom/impl/JoinRoomView.kt
@@ -80,6 +80,7 @@ fun JoinRoomView(
     onBackClick: () -> Unit,
     onJoinSuccess: () -> Unit,
     onKnockSuccess: () -> Unit,
+    onCancelKnockSuccess: () -> Unit,
     modifier: Modifier = Modifier,
 ) {
     Box(
@@ -139,7 +140,7 @@ fun JoinRoomView(
     )
     AsyncActionView(
         async = state.cancelKnockAction,
-        onSuccess = { state.eventSink(JoinRoomEvents.ClearActionStates) },
+        onSuccess = { onCancelKnockSuccess() },
         onErrorDismiss = { state.eventSink(JoinRoomEvents.ClearActionStates) },
         confirmationDialog = {
             ConfirmationDialog(
@@ -464,5 +465,6 @@ internal fun JoinRoomViewPreview(@PreviewParameter(JoinRoomStateProvider::class)
         onBackClick = { },
         onJoinSuccess = { },
         onKnockSuccess = { },
+        onCancelKnockSuccess = { },
     )
 }