Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accent color for Checkbox, RadioButton and Switch components #3728

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Oct 23, 2024

Content

The 'selected' color for these components is now green.

Motivation and context

Changes in the Compound designs.

Screenshots / GIFs

Before After
image image
image image
image image

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Misc For other changes label Oct 23, 2024
@jmartinesp jmartinesp requested a review from a team as a code owner October 23, 2024 15:31
@jmartinesp jmartinesp requested review from ganfra and removed request for a team October 23, 2024 15:31
Copy link
Contributor

github-actions bot commented Oct 23, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/hnTiyf

Copy link

sonarcloud bot commented Oct 23, 2024

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.05%. Comparing base (f1e8d3f) to head (b027d76).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3728   +/-   ##
========================================
  Coverage    83.05%   83.05%           
========================================
  Files         1753     1753           
  Lines        43825    43828    +3     
  Branches      5127     5127           
========================================
+ Hits         36397    36400    +3     
  Misses        5611     5611           
  Partials      1817     1817           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 24, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) October 24, 2024 08:12
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 24, 2024
@jmartinesp jmartinesp merged commit 384c4a5 into develop Oct 24, 2024
29 of 30 checks passed
@jmartinesp jmartinesp deleted the misc/compound-update-accent-color-to-checboxes-radio-buttons-and-switches branch October 24, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants