-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incoming session verification #3733
Draft
bmarty
wants to merge
6
commits into
develop
Choose a base branch
from
feature/bma/incomingVerification
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
commented
Oct 24, 2024
.../io/element/android/features/verifysession/impl/incoming/IncomingVerificationStateMachine.kt
Outdated
Show resolved
Hide resolved
bmarty
force-pushed
the
feature/bma/incomingVerification
branch
from
October 24, 2024 13:36
ebd865f
to
31f171f
Compare
bmarty
changed the base branch from
develop
to
feature/valere/bump_rust_sdk_0.2.57
October 24, 2024 13:37
BillCarsonFr
force-pushed
the
feature/valere/bump_rust_sdk_0.2.57
branch
from
October 24, 2024 14:17
adf4442
to
4ef231c
Compare
Base automatically changed from
feature/valere/bump_rust_sdk_0.2.57
to
develop
October 24, 2024 14:45
An error occurred while trying to automatically change base from
feature/valere/bump_rust_sdk_0.2.57
to
develop
October 24, 2024 14:45
Add more log to the state machines Ensure the block cannot be cancelled, else if the Rust SDK emit a new state during the API execution, the state machine may cancel the api call. Let VerificationFlowState values match the SDK api for code clarity. Rename sub interface for clarity. Migrate tests to the new FakeVerificationService.
…uild with the current SDK version.
bmarty
force-pushed
the
feature/bma/incomingVerification
branch
from
October 25, 2024 08:12
31f171f
to
e554f84
Compare
bmarty
added
the
Record-Screenshots
Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found.
label
Oct 25, 2024
github-actions
bot
removed
the
Record-Screenshots
Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found.
label
Oct 25, 2024
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
bmarty
added
the
Run-Maestro
Starts a Maestro Cloud session to run integration tests
label
Oct 25, 2024
github-actions
bot
removed
the
Run-Maestro
Starts a Maestro Cloud session to run integration tests
label
Oct 25, 2024
Remove extra parenthesis Naming rules Import order
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, will need an SDK update. Opening the PR to be able to discuss the content.
Here is a quick demo of the feature:
IncomingVerification.mp4