Hitting resend on failed msg doesn’t reset its send status

[ara4n]

Steps to reproduce

1. Tried to send two msgs
2. For whatever reason (bad connectivity? server problems?) they failed.
3. Conversation moved on
4. I hit retry on the first one
5. It moved to the bottom of the timeline, but was still marked as failed-send (i guess it might have immediately failed?). i expected it to move back to sending/unsent state, not failed
6. I then did the second one; same result. Plus very annoying to have to individually resend them.

Outcome

What did you expect?

resending should be shown as resending, not failed.

Your phone model

No response

Operating system version

No response

Application version

292

Homeserver

No response

Will you send logs?

Yes

[Hywan]

Hi,

In the remote_echo_full_trip unit test, we ensure that the EventSendState evolves as expecting when an event is sent, has failed to be sent etc.

In the echo integration test, we test a successful send of an event against a server.

In the retry_failed integration test, we test a send that fails, then is retried, against a server.

I strongly believe that what you see is a very fast retry that ends up failing, like the first send.

To avoid this “nothing has happened??” feeling, the UI may run an animation when retrying, or displaying something to the user that deliberately “takes time”. Thoughts?

[ara4n]

yup, some kind of animation would solve the perception that the retry hasn't happened.

[Velin92]

@kittykat
I can look into it, but if as explained by @Hywan this is just another resend failing again because the connectivity is bad this requires actually some kind of UI/UX changes and we should include design in it. Since this issue seems to happen when a resend fails again because the connectivity is still bad and having no visual indication that it has failed.