Artificial delay when a message fails to send #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 52754d7 |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2091 +/- ##
===========================================
+ Coverage 69.67% 69.93% +0.26%
===========================================
Files 522 522
Lines 36292 36319 +27
Branches 17552 17565 +13
===========================================
+ Hits 25286 25400 +114
+ Misses 10366 10279 -87
Partials 640 640
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stefanceriu
approved these changes
Nov 16, 2023
ElementX/Sources/Screens/RoomScreen/View/Style/TimelineStyler.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Style/TimelineStyler.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1352
Since in poor internet conditions (or when completely offline) the resend action fails pretty much immediately there is no visual indication that it has failed again. so the idea is to create an artificial delay of about 0.5 seconds when the status transitions to
sendingFailedto make it look like for a brief moment that is being sent to give a visual cue that the user that the app has actively tried to resend the messageSimulator.Screen.Recording.-.iPhone.14.-.2023-11-15.at.19.09.41.mp4