Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Remove options for share & edit from Avatar detail view screen #2001

Closed
kittykat opened this issue Nov 1, 2023 · 4 comments
Closed
Assignees
Labels
A-Room-Detail A-User-Detail O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect

Comments

@kittykat
Copy link
Contributor

kittykat commented Nov 1, 2023

Steps to reproduce

  1. Go to a user detail page for another user
  2. Click on their avatar

Outcome

What did you expect?

I do not have the options for forwarding, editing and doing an "iOS search" for another user's avatar.

What happened instead?

The UI shows me options that I shouldn't be able to take

Internal reference: iOSX-5

Will you send logs?

No

@pixlwave pixlwave added S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely A-Room-Detail A-User-Detail labels Nov 2, 2023
@pixlwave
Copy link
Member

pixlwave commented Nov 2, 2023

@kittykat Assuming you have the same comments for the room avatar too?

Adding a few thoughts:

  • The share option is useful to save an avatar to your device rather than forcing users to screenshot the image cringe
  • What is an "iOS search", I can't see how to trigger any search in that screen?

Edit: Also context - just like media previews we're using QuickLook here as it gave us the majority of the desired result without much effort to implement the feature quickly.

@pixlwave
Copy link
Member

pixlwave commented Nov 2, 2023

@VolkerJunginger I think you might have more context 👆

@VolkerJunginger
Copy link

I can understand that our users would like to have this more as an magnifier feature.

Is it maybe easier to implement a quick-look functionality like for example instagram is having?

RPReplay_Final1699950133.MP4

@VolkerJunginger
Copy link

Please, remove all actions form the image screen, so this is just an option to magnify the image.

@VolkerJunginger VolkerJunginger changed the title Update avatar preview screen [iOS] Remove options for share & edit from Avatar detail view screen Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-Detail A-User-Detail O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants