Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back default controls for QuickLook based media viewers #3254

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

stefanceriu
Copy link
Member

Not a lot else to say:

Simulator.Screen.Recording.-.iPhone.15.-.2024-09-10.at.17.56.33.mp4

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Sep 10, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner September 10, 2024 15:02
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team September 10, 2024 15:02
Copy link

github-actions bot commented Sep 10, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e7989f8

@pixlwave
Copy link
Member

Linking this here with what we hid all of the controls to accomplish.

#2001

@stefanceriu stefanceriu changed the title Fixes #3243 - Bring back default controls for QuickLook based media viewers Bring back default controls for QuickLook based media viewers Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.02%. Comparing base (4ec6098) to head (e7989f8).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...reens/FilePreviewScreen/InteractiveQuickLook.swift 20.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3254      +/-   ##
===========================================
+ Coverage    71.01%   71.02%   +0.01%     
===========================================
  Files          734      735       +1     
  Lines        65131    65246     +115     
===========================================
+ Hits         46255    46344      +89     
- Misses       18876    18902      +26     
Flag Coverage Δ
unittests 68.76% <38.46%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanceriu stefanceriu merged commit ff5b22c into develop Sep 11, 2024
6 checks passed
@stefanceriu stefanceriu deleted the stefan/3243 branch September 11, 2024 09:11
Copy link

sonarcloud bot commented Sep 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants