-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactions: Add more button #1314
Conversation
- Adds a CollapsibleFlowLayout for controlling the layout - Adds tests for this layout and some mocks for testing layouts generally - Improves the rendering of the reaction buttons which were not pixel perfect - Adds the UI for the expand collapse buttons including the count of hidden items in the collapsed state.
…c and account for the add more button specifics.
…into langleyd/reactions_add_more_button
- create ReactionLayoutItemType to tag subviews with ReactionLayoutItem - Add LayoutValueKey support to the layout mocks - Fix some mistakes in the merge - Make the test code a bit more DRY - Make the animation of the addMore and collapse buttons consistent
…into langleyd/reactions_add_more_button
Generated by 🚫 Danger Swift against 1fe7dc8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to look at the changes in the flow layout, but finishing for today so posting this for now :)
.../Resources/Assets.xcassets/images/timeline/timeline-reaction-add-more.imageset/Contents.json
Outdated
Show resolved
Hide resolved
ElementX/Sources/Other/CollapsibleFlowLayout/CollapsibleReactionLayout.swift
Outdated
Show resolved
Hide resolved
- Fix typos - Use pdf/svg for icon - Fix incorrect padding from a bad merge
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1314 +/- ##
===========================================
+ Coverage 44.05% 44.62% +0.57%
===========================================
Files 397 435 +38
Lines 26306 28053 +1747
Branches 13387 14349 +962
===========================================
+ Hits 11588 12518 +930
- Misses 14424 15219 +795
- Partials 294 316 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay coming back to this one. LGTM 👍
.../Resources/Assets.xcassets/images/timeline/timeline-reaction-add-more.imageset/Contents.json
Show resolved
Hide resolved
ElementX/Sources/Other/CollapsibleFlowLayout/CollapsibleReactionLayout.swift
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What's in this PR
ReactionLayoutItemType
LayoutValueKey
to tag subviews withReactionLayoutItem
LayoutValueKey
support to the layout mocksWhat does it look like