Reactions: Add more button #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a CollapsibleFlowLayout for controlling the layout - Adds tests for this layout and some mocks for testing layouts generally - Improves the rendering of the reaction buttons which were not pixel perfect - Adds the UI for the expand collapse buttons including the count of hidden items in the collapsed state.
…c and account for the add more button specifics.
…into langleyd/reactions_add_more_button
- create ReactionLayoutItemType to tag subviews with ReactionLayoutItem - Add LayoutValueKey support to the layout mocks - Fix some mistakes in the merge - Make the test code a bit more DRY - Make the animation of the addMore and collapse buttons consistent
…into langleyd/reactions_add_more_button
Generated by 🚫 Danger Swift against 1fe7dc8 |
pixlwave
reviewed
Jul 12, 2023
.../Resources/Assets.xcassets/images/timeline/timeline-reaction-add-more.imageset/Contents.json
Outdated
Show resolved
Hide resolved
ElementX/Sources/Other/CollapsibleFlowLayout/CollapsibleReactionLayout.swift
Outdated
Show resolved
Hide resolved
- Fix typos - Use pdf/svg for icon - Fix incorrect padding from a bad merge
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1314 +/- ##
===========================================
+ Coverage 44.05% 44.62% +0.57%
===========================================
Files 397 435 +38
Lines 26306 28053 +1747
Branches 13387 14349 +962
===========================================
+ Hits 11588 12518 +930
- Misses 14424 15219 +795
- Partials 294 316 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pixlwave
approved these changes
Jul 14, 2023
.../Resources/Assets.xcassets/images/timeline/timeline-reaction-add-more.imageset/Contents.json
Show resolved
Hide resolved
ElementX/Sources/Other/CollapsibleFlowLayout/CollapsibleReactionLayout.swift
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR
ReactionLayoutItemTypeLayoutValueKeyto tag subviews withReactionLayoutItemLayoutValueKeysupport to the layout mocksWhat does it look like