-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort reactions on the timeline by count and then timestamp and show the date on the summary view #1320
Conversation
- Sort reaction aggregations on the timeline by count and then by most recent timestamp ascending(tagging new reactions on the end) - Show the timestamp on the summary view and sort descending(newest at the top)
Generated by 🚫 Danger Swift against 5bbbcbd |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1320 +/- ##
===========================================
- Coverage 44.05% 43.96% -0.09%
===========================================
Files 397 398 +1
Lines 26306 26309 +3
Branches 13387 13394 +7
===========================================
- Hits 11588 11568 -20
- Misses 14424 14446 +22
- Partials 294 295 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😎
ElementX/Sources/Screens/RoomScreen/View/Supplementary/ReactionsSummaryView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineItemContent/AggregratedReaction.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift
Show resolved
Hide resolved
- Fix ID case. - Improve readability of components in body. - Improve the comments that describe the sorting.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixes #1289 |
What's in this PR
What does it look like