Sort reactions on the timeline by count and then timestamp and show the date on the summary view #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sort reaction aggregations on the timeline by count and then by most recent timestamp ascending(tagging new reactions on the end) - Show the timestamp on the summary view and sort descending(newest at the top)
Generated by 🚫 Danger Swift against 5bbbcbd |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1320 +/- ##
===========================================
- Coverage 44.05% 43.96% -0.09%
===========================================
Files 397 398 +1
Lines 26306 26309 +3
Branches 13387 13394 +7
===========================================
- Hits 11588 11568 -20
- Misses 14424 14446 +22
- Partials 294 295 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pixlwave
approved these changes
Jul 13, 2023
ElementX/Sources/Screens/RoomScreen/View/Supplementary/ReactionsSummaryView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineItemContent/AggregratedReaction.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift
Show resolved
Hide resolved
- Fix ID case. - Improve readability of components in body. - Improve the comments that describe the sorting.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Fixes #1289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR
What does it look like