-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Tests fixes. #1322
UI Tests fixes. #1322
Conversation
Generated by 🚫 Danger Swift against 508c6f1 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1322 +/- ##
===========================================
- Coverage 44.56% 44.43% -0.13%
===========================================
Files 434 434
Lines 27836 27836
Branches 14262 14262
===========================================
- Hits 12404 12370 -34
- Misses 15120 15154 +34
Partials 312 312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine from the perf timing interactions - we could even run the UI tests 7 days a week, rather than just mon-fri (1-5) - the machine will be idle otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR makes various changes to UI tests:
Awaiting result from run here.