UI Tests fixes. #1322

pixlwave · 2023-07-13T11:35:35Z

This PR makes various changes to UI tests:

Fix stale snapshots.
Fix incorrect placeholder coordinator.
Move runs to the performance testing runner.
Sync runs to every 12 hours with a 6 hour offset compared to integration tests.
Reset the simulator before each run (likely unnecessary but does fix the keyboard being hidden)
Zip the test results bundle to speed up uploads as it contains lots of little files.

Awaiting result from run here.

Tweak workflow.

github-actions · 2023-07-13T11:36:53Z

	Warnings
⚠️	Please add a changelog.
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 508c6f1

codecov · 2023-07-13T11:52:08Z

Codecov Report

Patch coverage has no change and project coverage change: -0.13 ⚠️

Comparison is base (3ff257c) 44.56% compared to head (35000ab) 44.43%.

❗ Current head 35000ab differs from pull request most recent head 508c6f1. Consider uploading reports for the commit 508c6f1 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1322      +/-   ##
===========================================
- Coverage    44.56%   44.43%   -0.13%     
===========================================
  Files          434      434              
  Lines        27836    27836              
  Branches     14262    14262              
===========================================
- Hits         12404    12370      -34     
- Misses       15120    15154      +34     
  Partials       312      312

Flag	Coverage Δ
unittests	`23.41% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

michaelkaye

This looks fine from the perf timing interactions - we could even run the UI tests 7 days a week, rather than just mon-fri (1-5) - the machine will be idle otherwise.