Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redacting is now displayed for moderators in groups #1324

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 13, 2023

If the room is not direct we can now check if the current user is actually able to redact a message or not.

This requires an SDK update.

@Velin92 Velin92 linked an issue Jul 13, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift#L83 - Function body should span 50 lines or less excluding comments and whitespace: currently spans 54 lines (function_body_length)

⚠️

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift#L444 - SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

Generated by 🚫 Danger Swift against 42b26dd

@Velin92 Velin92 force-pushed the mauroromito/redact-shows-for-moderators branch from 3033073 to 95f734d Compare July 14, 2023 07:57
@Velin92 Velin92 requested a review from pixlwave July 14, 2023 08:28
@Velin92 Velin92 force-pushed the mauroromito/redact-shows-for-moderators branch from 95f734d to a9481fd Compare July 14, 2023 08:29
@Velin92 Velin92 force-pushed the mauroromito/redact-shows-for-moderators branch from a9481fd to bb33b35 Compare July 14, 2023 14:01
@Velin92 Velin92 marked this pull request as ready for review July 18, 2023 09:43
@Velin92 Velin92 requested a review from a team as a code owner July 18, 2023 09:43
@Velin92 Velin92 force-pushed the mauroromito/redact-shows-for-moderators branch from bb33b35 to 1c5a0f4 Compare July 18, 2023 09:43
@Velin92 Velin92 enabled auto-merge (squash) July 18, 2023 10:05
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 7.40% and project coverage change: -0.04 ⚠️

Comparison is base (c83a2bd) 44.20% compared to head (330b351) 44.16%.

❗ Current head 330b351 differs from pull request most recent head 42b26dd. Consider uploading reports for the commit 42b26dd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1324      +/-   ##
===========================================
- Coverage    44.20%   44.16%   -0.04%     
===========================================
  Files          399      399              
  Lines        26548    26572      +24     
  Branches     13493    13506      +13     
===========================================
+ Hits         11735    11736       +1     
- Misses       14511    14534      +23     
  Partials       302      302              
Flag Coverage Δ
unittests 22.57% <7.40%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mentX/Sources/Mocks/Generated/GeneratedMocks.swift 23.72% <ø> (ø)
ElementX/Sources/Services/Room/RoomProxy.swift 0.00% <0.00%> (ø)
...entX/Sources/Services/Room/RoomProxyProtocol.swift 60.00% <ø> (ø)
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 43.26% <12.50%> (-0.80%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Velin92 Velin92 disabled auto-merge July 18, 2023 10:35
@Velin92 Velin92 enabled auto-merge (squash) July 18, 2023 10:35
@Velin92 Velin92 force-pushed the mauroromito/redact-shows-for-moderators branch from 330b351 to 42b26dd Compare July 18, 2023 13:36
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 merged commit 19ecf90 into develop Jul 18, 2023
5 checks passed
@Velin92 Velin92 deleted the mauroromito/redact-shows-for-moderators branch July 18, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redact/Delete message options for moderators in a room
2 participants