-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SwiftUI timeline refactor + TimelineViewState decoupling #1392
Conversation
…e scroll the perfomance diminishes not sure what may be causing it
a609b1d
to
3f1db81
Compare
Generated by 🚫 Danger Swift against b1950b7 |
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/h9ditF |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1392 +/- ##
===========================================
- Coverage 45.33% 44.74% -0.60%
===========================================
Files 388 389 +1
Lines 24716 24871 +155
Branches 12604 12686 +82
===========================================
- Hits 11205 11128 -77
- Misses 13224 13462 +238
+ Partials 287 281 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments but otherwise I absolutely love it! 👏👏👏
ElementX/Sources/Screens/RoomScreen/View/Supplementary/TimelineItemStatusView.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/CollapsibleRoomTimelineView.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing, love it! 🤩
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemView.swift
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This is the best approach I could achieve so far.
The performances are great, the timeline has never been so fast. The animations look very clean, sending messages and pagination are faster than ever (probably their updates were delayed by a ton of main thread async updates before).
Animations that did not work previously now work, for example now Collapsible items are animated.
https://drive.google.com/file/d/1waiVkKgY-0Xhw3g3wdcH6SLHa0kVT_4P/view?usp=drive_link