-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit the room Notification setting #1394
Conversation
Generated by 🚫 Danger Swift against 3c8ab5b |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1394 +/- ##
===========================================
+ Coverage 44.83% 45.50% +0.67%
===========================================
Files 389 394 +5
Lines 24886 25153 +267
Branches 12694 12838 +144
===========================================
+ Hits 11157 11446 +289
+ Misses 13445 13418 -27
- Partials 284 289 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
e895ed9
to
b61a464
Compare
...tX/Sources/Screens/RoomNotificationSettingsScreen/RoomNotificationSettingsScreenModels.swift
Outdated
Show resolved
Hide resolved
...tX/Sources/Screens/RoomNotificationSettingsScreen/RoomNotificationSettingsScreenModels.swift
Outdated
Show resolved
Hide resolved
...tX/Sources/Screens/RoomNotificationSettingsScreen/RoomNotificationSettingsScreenModels.swift
Outdated
Show resolved
Hide resolved
...tX/Sources/Screens/RoomNotificationSettingsScreen/RoomNotificationSettingsScreenModels.swift
Outdated
Show resolved
Hide resolved
...Sources/Screens/RoomNotificationSettingsScreen/RoomNotificationSettingsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
...Sources/Screens/RoomNotificationSettingsScreen/RoomNotificationSettingsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
...Sources/Screens/RoomNotificationSettingsScreen/RoomNotificationSettingsScreenViewModel.swift
Show resolved
Hide resolved
ElementX/Sources/Services/NotificationSettings/NotificationSettingsProxy.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/NotificationSettings/NotificationSettingsProxy.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Other/SwiftUI/Form Styles/FormButtonStyles.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small comments looking at the use of Compound :)
...ntX/Sources/Screens/RoomNotificationSettingsScreen/View/RoomNotificationSettingsScreen.swift
Outdated
Show resolved
Hide resolved
...ntX/Sources/Screens/RoomNotificationSettingsScreen/View/RoomNotificationSettingsScreen.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tweaks, looks good to me from the perspective of Compound 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
51593bc
to
3c8ab5b
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR implements #1004 to define the notification setting for a room.