-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"View only" polls in the timeline #1399
Conversation
Generated by 🚫 Danger Swift against a6a295a |
ff70252
to
d723a78
Compare
bec4907
to
6a13ecd
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1399 +/- ##
===========================================
- Coverage 45.80% 45.60% -0.20%
===========================================
Files 394 396 +2
Lines 25510 25667 +157
Branches 12974 13027 +53
===========================================
+ Hits 11684 11706 +22
- Misses 13531 13666 +135
Partials 295 295
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question
0d4c503
to
a6a295a
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR renders the polls created with other clients.
Notes
iPhone
iPad