Update RoomScreen and UserSessionScreen UI tests #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velin92
commented
Jul 25, 2023
Velin92
commented
Jul 25, 2023
...urces/__Snapshots__/Application/en-GB-iPad-9th-generation.roomSmallTimelineWithReactions.png
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger Swift against d408139 |
pixlwave
reviewed
Jul 25, 2023
UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.roomLayoutBottom-1.png
Outdated
Show resolved
Hide resolved
pixlwave
reviewed
Jul 25, 2023
UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.roomLayoutMiddle-1.png
Outdated
Show resolved
Hide resolved
pixlwave
reviewed
Jul 25, 2023
UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.roomLayoutBottom-1.png
Outdated
Show resolved
Hide resolved
pixlwave
approved these changes
Jul 25, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1400 +/- ##
===========================================
- Coverage 45.00% 44.81% -0.20%
===========================================
Files 389 389
Lines 24853 24894 +41
Branches 12686 12699 +13
===========================================
- Hits 11186 11157 -29
- Misses 13386 13453 +67
- Partials 281 284 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
there is an issue with layoutBottom ones fixing it |
Velin92
force-pushed
the
mauroromito/update_room_and_user_ui_tests
branch
from
9e311fd
to
9fe2e89
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Velin92
force-pushed
the
mauroromito/update_room_and_user_ui_tests
branch
from
9fe2e89
to
d408139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.