-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RoomScreen and UserSessionScreen UI tests #1400
Conversation
...urces/__Snapshots__/Application/en-GB-iPad-9th-generation.roomSmallTimelineWithReactions.png
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger Swift against d408139 |
UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.roomLayoutBottom-1.png
Outdated
Show resolved
Hide resolved
UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.roomLayoutMiddle-1.png
Outdated
Show resolved
Hide resolved
UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.roomLayoutBottom-1.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of keyboards missing, otherwise lgtm
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1400 +/- ##
===========================================
- Coverage 45.00% 44.81% -0.20%
===========================================
Files 389 389
Lines 24853 24894 +41
Branches 12686 12699 +13
===========================================
- Hits 11186 11157 -29
- Misses 13386 13453 +67
- Partials 281 284 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
there is an issue with layoutBottom ones fixing it |
9e311fd
to
9fe2e89
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
9fe2e89
to
d408139
Compare
No description provided.