Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting to TableView but with SwiftUI compatibility #1407

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Reverting to TableView but with SwiftUI compatibility #1407

merged 5 commits into from
Jul 26, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 26, 2023

Also if we really want to test and play around in nightly with SwiftUI I have set up a feature flag that allows us to change the timeline to SwiftUI whenever we wish.

@Velin92 Velin92 requested a review from a team as a code owner July 26, 2023 13:14
@Velin92 Velin92 requested review from stefanceriu and removed request for a team July 26, 2023 13:14
@github-actions
Copy link

github-actions bot commented Jul 26, 2023 •
edited
Loading

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift#L460 - SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

Generated by 🚫 Danger Swift against 06b3d2e

pixlwave
pixlwave approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waves bye bye to smoothness for now 😢

ElementX/Sources/Application/AppSettings.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/RoomScreen/View/RoomScreen.swift Show resolved Hide resolved
ElementX/Sources/Screens/RoomScreen/View/TimelineView.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/RoomScreen/View/RoomScreen.swift Outdated Show resolved Hide resolved
@Velin92 Velin92 enabled auto-merge (squash) July 26, 2023 13:47
@Velin92 Velin92 disabled auto-merge July 26, 2023 13:48
@Velin92 Velin92 enabled auto-merge (squash) July 26, 2023 13:48
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 merged commit 99b5bf5 into develop Jul 26, 2023
5 checks passed
@Velin92 Velin92 deleted the mauroromito/reverting_to_tableview_but_keep_compatibility branch July 26, 2023 13:53
@alfogrillo alfogrillo mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@stefanceriu stefanceriu Awaiting requested review from stefanceriu stefanceriu is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velin92 @pixlwave