Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to 1.0.102-alpha #1408

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Update SDK to 1.0.102-alpha #1408

merged 4 commits into from
Jul 27, 2023

Conversation

alfogrillo
Copy link
Contributor

No description provided.

@alfogrillo alfogrillo requested a review from a team as a code owner July 26, 2023 19:07
@alfogrillo alfogrillo requested review from Velin92, stefanceriu and pixlwave and removed request for a team July 26, 2023 19:07
@github-actions
Copy link

github-actions bot commented Jul 26, 2023

Warnings
⚠️ Please provide a description for this PR.
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️

ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift#L210 - SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

Generated by 🚫 Danger Swift against 789599f

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (90ff2df) 45.82% compared to head (962e409) 45.80%.
Report is 1 commits behind head on develop.

❗ Current head 962e409 differs from pull request most recent head 789599f. Consider uploading reports for the commit 789599f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1408      +/-   ##
===========================================
- Coverage    45.82%   45.80%   -0.02%     
===========================================
  Files          394      394              
  Lines        25496    25502       +6     
  Branches     12964    12968       +4     
===========================================
- Hits         11683    11682       -1     
- Misses       13518    13524       +6     
- Partials       295      296       +1     
Flag Coverage Δ
unittests 22.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ces/Notification/Proxy/NotificationItemProxy.swift 0.00% <0.00%> (ø)
ElementX/Sources/Services/Room/RoomProxy.swift 0.00% <0.00%> (ø)
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 0.00% <0.00%> (ø)
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% <0.00%> (ø)
...meline/TimelineItems/RoomTimelineItemFactory.swift 1.37% <0.00%> (-0.01%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alfogrillo alfogrillo self-assigned this Jul 26, 2023
@alfogrillo alfogrillo enabled auto-merge (squash) July 27, 2023 09:23
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alfogrillo alfogrillo merged commit 1529b5b into develop Jul 27, 2023
5 checks passed
@alfogrillo alfogrillo deleted the alfogrillo/update_sdk branch July 27, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants