-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alert the user about configuration mismatch in notification settings #1543
Alert the user about configuration mismatch in notification settings #1543
Conversation
Generated by 🚫 Danger Swift against d1772ca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
...X/Sources/Screens/Settings/NotificationSettingsScreen/NotificationSettingsScreenModels.swift
Outdated
Show resolved
Hide resolved
...X/Sources/Screens/Settings/NotificationSettingsScreen/NotificationSettingsScreenModels.swift
Show resolved
Hide resolved
...ources/Screens/Settings/NotificationSettingsScreen/NotificationSettingsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
...tX/Sources/Screens/Settings/NotificationSettingsScreen/View/NotificationSettingsScreen.swift
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1543 +/- ##
===========================================
- Coverage 52.91% 52.71% -0.21%
===========================================
Files 406 406
Lines 27021 27104 +83
Branches 13412 13446 +34
===========================================
- Hits 14299 14287 -12
- Misses 12336 12437 +101
+ Partials 386 380 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
b730ef9
to
d1772ca
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR implements the last part of #1024 to alert the user of a misconfiguration in their default notification settings.
In ElX, we no longer distinguish between encrypted and non-encrypted chats for notification settings, so it's possible to have different settings for encrypted and non-encrypted direct chats.
If the user chooses to continue, the settings will be updated so that the same mode is defined for both encrypted and non-encrypted chats.