Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert the user about configuration mismatch in notification settings #1543

Merged

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Aug 22, 2023

This PR implements the last part of #1024 to alert the user of a misconfiguration in their default notification settings.

In ElX, we no longer distinguish between encrypted and non-encrypted chats for notification settings, so it's possible to have different settings for encrypted and non-encrypted direct chats.

If the user chooses to continue, the settings will be updated so that the same mode is defined for both encrypted and non-encrypted chats.

@nimau nimau requested a review from a team as a code owner August 22, 2023 16:37
@nimau nimau requested review from alfogrillo and pixlwave and removed request for a team and alfogrillo August 22, 2023 16:37
@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against d1772ca

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nimau nimau requested a review from pixlwave August 23, 2023 12:46
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 21.78% and project coverage change: -0.21% ⚠️

Comparison is base (beeb5fc) 52.91% compared to head (b730ef9) 52.71%.
Report is 2 commits behind head on develop.

❗ Current head b730ef9 differs from pull request most recent head d1772ca. Consider uploading reports for the commit d1772ca to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1543      +/-   ##
===========================================
- Coverage    52.91%   52.71%   -0.21%     
===========================================
  Files          406      406              
  Lines        27021    27104      +83     
  Branches     13412    13446      +34     
===========================================
- Hits         14299    14287      -12     
- Misses       12336    12437     +101     
+ Partials       386      380       -6     
Flag Coverage Δ
unittests 23.12% <21.78%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...mentX/Sources/Other/AccessibilityIdentifiers.swift 93.05% <0.00%> (-1.32%) ⬇️
...ttingsScreen/View/NotificationSettingsScreen.swift 0.00% <0.00%> (ø)
...gsScreen/NotificationSettingsScreenViewModel.swift 82.24% <72.41%> (-1.78%) ⬇️
...tingsScreen/NotificationSettingsScreenModels.swift 54.83% <100.00%> (+1.50%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimau nimau force-pushed the nicolas/1026-notification-settings-configuration-mismatch branch from b730ef9 to d1772ca Compare August 23, 2023 13:32
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.1% 8.1% Duplication

@nimau nimau enabled auto-merge (squash) August 23, 2023 13:33
@nimau nimau merged commit e0f885c into develop Aug 23, 2023
5 checks passed
@nimau nimau deleted the nicolas/1026-notification-settings-configuration-mismatch branch August 23, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants