-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar Bloom View in home screen navigation bar #1630
Conversation
c293b70
to
12dfe7a
Compare
Generated by 🚫 Danger Swift against 9df6213 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1630 +/- ##
===========================================
- Coverage 58.63% 58.38% -0.25%
===========================================
Files 412 413 +1
Lines 28217 28329 +112
Branches 14058 14097 +39
===========================================
- Hits 16545 16541 -4
- Misses 11214 11331 +117
+ Partials 458 457 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
55fbaac
to
680f15e
Compare
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3iW5MH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the demos and test build, Mauro! We're getting super close to the final implementation.
- Blending modes: We updated the values as follows. Light theme has a
Hard Light
bottom layer @ 20% opacity, and a topColor
layer @ 80% opacity. Dark theme has aExclusion
bottom layer @ 50% opacity, and a topColor
layer @ 20% opacity - Soft edge mask: We settled 40px/pt for the linear gradient height.
- Collapsed navigation bar: The bloom shouldn't change its position, if possible, and just be cropped instead (e.g., behavior on Android).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the latest screenshots that @Velin92 just shared over DM.
- When the Navigation Bar is not collapsed, the linear gradient mask for the "soft edge" effect seems to not be properly placed, there's a small visible gap.
- When the Navigation Bar is collapsed, we don't have to render the linear gradient mask for the "soft edge" effect.
- We should restore the hairline border on the Navigation Bar bottom.
e69dcd9
to
fbf786b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏👏👏
…ent should get hidden while in search mode
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
ec31f37
to
5794a42
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Simulator.Screen.Recording.-.iPhone.14.-.2023-09-07.at.16.24.07.mp4