Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification fixes #1633

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Notification fixes #1633

merged 2 commits into from
Sep 6, 2023

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu requested a review from a team as a code owner September 5, 2023 12:36
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team September 5, 2023 12:36
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 23af12a

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11% ⚠️

Comparison is base (d8fa82d) 58.34% compared to head (23af12a) 58.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1633      +/-   ##
===========================================
- Coverage    58.34%   58.23%   -0.11%     
===========================================
  Files          410      410              
  Lines        27696    27701       +5     
  Branches     13748    13748              
===========================================
- Hits         16159    16132      -27     
- Misses       11092    11126      +34     
+ Partials       445      443       -2     
Flag Coverage Δ
unittests 22.78% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ElementX/Sources/Application/AppCoordinator.swift 57.34% <0.00%> (-0.47%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanceriu stefanceriu merged commit 3bc474f into develop Sep 6, 2023
9 checks passed
@stefanceriu stefanceriu deleted the stefan/notificationFixes branch September 6, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong unread count on desktop icon (macOS)
2 participants