Prefire basic implementation #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velin92
requested review from
pixlwave and
stefanceriu
and removed request for
a team
Generated by 🚫 Danger Swift against 5d6355f |
Velin92
force-pushed
the
mauroromito/prefire_preview_testing
branch
from
f6dd2f8
to
69edce6
Compare
pixlwave
reviewed
Sep 19, 2023
UnitTests/Sources/__Snapshots__/PreviewTests.generated/test_timelineItemStyler.Plain.png
Outdated
Show resolved
Hide resolved
pixlwave
reviewed
Sep 19, 2023
Velin92
force-pushed
the
mauroromito/prefire_preview_testing
branch
2 times, most recently
from
c8d77a6
to
4bd6e0d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1743 +/- ##
===========================================
+ Coverage 58.51% 59.19% +0.67%
===========================================
Files 428 428
Lines 29127 29127
Branches 14363 14363
===========================================
+ Hits 17045 17241 +196
+ Misses 11607 11405 -202
- Partials 475 481 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Velin92
force-pushed
the
mauroromito/prefire_preview_testing
branch
2 times, most recently
from
2d5b14a
to
b1d977d
Compare
stefanceriu
approved these changes
Sep 20, 2023
force the unit tests to run on iPhone 14 skipping plugin validation archive artifacts better workflow removed the OS restriction lfs custom stencil new test file deleting
Velin92
force-pushed
the
mauroromito/prefire_preview_testing
branch
from
b1d977d
to
5d6355f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this includes a basic but tweakable configuration of Prefire with one single Preview test.
We probably need to decide if we want to have a different test suite just for the preview testing or if we are okay running unit tests with this configuration (iPhone 14 iOS 16) on the CI and also locally always.
After this is merged I'll proceed into making another PR were I make all our Previews testable, which should bump also the code coverage by a lot and increase resilience to breaking view changes