-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefire basic implementation #1743
Conversation
Generated by 🚫 Danger Swift against 5d6355f |
f6dd2f8
to
69edce6
Compare
UnitTests/Sources/__Snapshots__/PreviewTests.generated/test_timelineItemStyler.Plain.png
Outdated
Show resolved
Hide resolved
c8d77a6
to
4bd6e0d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1743 +/- ##
===========================================
+ Coverage 58.51% 59.19% +0.67%
===========================================
Files 428 428
Lines 29127 29127
Branches 14363 14363
===========================================
+ Hits 17045 17241 +196
+ Misses 11607 11405 -202
- Partials 475 481 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
2d5b14a
to
b1d977d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing, awesome job! 👏
force the unit tests to run on iPhone 14 skipping plugin validation archive artifacts better workflow removed the OS restriction lfs custom stencil new test file deleting
b1d977d
to
5d6355f
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
For now this includes a basic but tweakable configuration of Prefire with one single Preview test.
We probably need to decide if we want to have a different test suite just for the preview testing or if we are okay running unit tests with this configuration (iPhone 14 iOS 16) on the CI and also locally always.
After this is merged I'll proceed into making another PR were I make all our Previews testable, which should bump also the code coverage by a lot and increase resilience to breaking view changes