Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poll form UI tests #2251

Closed
wants to merge 1 commit into from
Closed

Fix poll form UI tests #2251

wants to merge 1 commit into from

Conversation

pixlwave
Copy link
Member

This is slower but is more reliable so I hope this is the tests done. Annoying that they work before merging and then fail once merged 🙈

@pixlwave pixlwave requested a review from a team as a code owner December 15, 2023 10:42
@pixlwave pixlwave requested review from Velin92 and removed request for a team December 15, 2023 10:42
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 79b775e

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f88d39) 71.37% compared to head (79b775e) 71.48%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2251      +/-   ##
===========================================
+ Coverage    71.37%   71.48%   +0.11%     
===========================================
  Files          517      517              
  Lines        35408    35408              
  Branches     17038    17038              
===========================================
+ Hits         25272    25311      +39     
+ Misses        9513     9476      -37     
+ Partials       623      621       -2     
Flag Coverage Δ
unittests 57.54% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu
Copy link
Member

Wrote a different fix for it [here] which seems to run on the CI just fine

@pixlwave pixlwave deleted the doug/poll-ui-tests branch January 8, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants