Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll options can be multiline during creation #2274

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Dec 20, 2023

fixes #2273

@Velin92 Velin92 requested a review from a team as a code owner December 20, 2023 11:19
@Velin92 Velin92 requested review from nimau and removed request for a team December 20, 2023 11:19
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 2299a2d

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (756b96f) 72.26% compared to head (2299a2d) 72.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2274      +/-   ##
===========================================
- Coverage    72.26%   72.18%   -0.09%     
===========================================
  Files          512      512              
  Lines        35227    35226       -1     
  Branches     16975    16973       -2     
===========================================
- Hits         25457    25428      -29     
- Misses        9137     9169      +32     
+ Partials       633      629       -4     
Flag Coverage Δ
unittests 57.78% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit e8da21e into develop Dec 20, 2023
9 checks passed
@Velin92 Velin92 deleted the mauroromito/multiline_options_in_poll_form branch December 20, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polls: Multiline for Options (Answers)
2 participants