Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identity pinning link. #3395

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix identity pinning link. #3395

merged 1 commit into from
Oct 10, 2024

Conversation

pixlwave
Copy link
Member

Based on element-hq/element-meta#2544 the link is missing part of the fragment.

@pixlwave pixlwave requested a review from a team as a code owner October 10, 2024 15:09
Copy link

github-actions bot commented Oct 10, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against b2b9d4d

@pixlwave pixlwave added the pr-bugfix for bug fix label Oct 10, 2024
@pixlwave pixlwave enabled auto-merge (squash) October 10, 2024 15:13
Copy link

sonarcloud bot commented Oct 10, 2024

@@ -126,7 +126,7 @@ final class AppSettings {
/// A URL where users can go read more about the chat backup.
let chatBackupDetailsURL: URL = "https://element.io/help#encryption5"
/// A URL where users can go read more about identity pinning violations
let identityPinningViolationDetailsURL: URL = "https://element.io/help#18"
let identityPinningViolationDetailsURL: URL = "https://element.io/help#encryption18"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked on Android we're good.

Copy link

codecov bot commented Oct 10, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
840 2 838 0
View the top 1 failed tests by shortest run time
PreviewTests test_roomDetailsScreen()
Stack Traces | 60s run time
Test exceeded execution time allowance of 1 minute (see `-[XCTestCase executionTimeAllowance]`)
View the full list of 1 ❄️ flaky tests
PreviewTests test_serverSelection()

Flake rate in main: 13.04% (Passed 20 times, Failed 3 times)

Stack Traces | 2.18s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_serverSelection-iPhone-16-en-GB.3.png"
@+
"file:.../tmp/PreviewTests/test_serverSelection-iPhone-16-en-GB.3.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.91864014 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave merged commit 71d6fcd into develop Oct 10, 2024
8 of 9 checks passed
@pixlwave pixlwave deleted the doug/fix-link branch October 10, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants