Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compound to change checkmark color #3440

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 23, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner October 23, 2024 15:46
@Velin92 Velin92 requested review from stefanceriu and removed request for a team October 23, 2024 15:46
@Velin92 Velin92 added the pr-change for updates to an existing feature label Oct 23, 2024
@Velin92 Velin92 requested a review from pixlwave October 23, 2024 15:46
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against c73e5a3

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarcloud bot commented Oct 23, 2024

@Velin92 Velin92 enabled auto-merge (squash) October 23, 2024 16:21
Copy link

codecov bot commented Oct 23, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
847 2 845 0
View the full list of 2 ❄️ flaky tests
PreviewTests test_serverSelection()

Flake rate in main: 16.67% (Passed 10 times, Failed 2 times)

Stack Traces | 1.83s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_serverSelection-iPhone-16-en-GB.3.png"
@+
"file:.../tmp/PreviewTests/test_serverSelection-iPhone-16-en-GB.3.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.91864014 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 18.59% (Passed 438 times, Failed 100 times)

Stack Traces | 4.38s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.848999 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@Velin92 Velin92 merged commit f26159a into develop Oct 23, 2024
13 checks passed
@Velin92 Velin92 deleted the mauroromito/update_compound branch October 23, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants