Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

min macos support #3451

Merged
merged 1 commit into from
Oct 25, 2024
Merged

min macos support #3451

merged 1 commit into from
Oct 25, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 25, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner October 25, 2024 08:13
@Velin92 Velin92 requested review from pixlwave and removed request for a team October 25, 2024 08:13
stefanceriu
stefanceriu approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 1ae27b2

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 added the pr-build for changes related to build, tools, CI/CD label Oct 25, 2024
@Velin92 Velin92 enabled auto-merge (rebase) October 25, 2024 08:35
@Velin92 Velin92 merged commit 35cbc84 into develop Oct 25, 2024
9 checks passed
@Velin92 Velin92 deleted the mauroromito/min_macos branch October 25, 2024 08:50
@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (2511c98) to head (1ae27b2).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3451      +/-   ##
===========================================
- Coverage    77.91%   77.86%   -0.06%     
===========================================
  Files          741      741              
  Lines        61116    61116              
===========================================
- Hits         47620    47587      -33     
- Misses       13496    13529      +33
Flag Coverage Δ
unittests 69.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

@pixlwave pixlwave Awaiting requested review from pixlwave pixlwave is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velin92 @stefanceriu