Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow coordinators #927

Merged
merged 2 commits into from
May 26, 2023
Merged

Flow coordinators #927

merged 2 commits into from
May 26, 2023

Commits on May 26, 2023

  1. Fixes #918, #919 - Introduce a RoomTimelineFlowCoordinator and relate… 

    …d FlowCoordinator protocol

Squashed commits:
Add unit tests and move the state machine into the FlowCoordinator
[bb68686] Replace the RoomFlowCoordinator's public interface with just `handleAppRoute`
[0d9a4f8] Remove the navigationStackCoordinator dependency from the roomScreenCoordinator
[4b5fbdf] Allow rooms to be selected from any other state
[41dbd12] Move all missing coordinators to the RoomFlowCoordinator and state machines
[f32431b] The UserSessionFlowCoordinator does not need to conform to the CoordinatorProtocol
[0f07e87] Fix leaving a room dismissing the currently selected one when different
[138385a] Rewind the navigation stack when re-selecting the same room (iPad)
[0727eb9] Fix presenting different room details from the side menu on iPads
[faf4cc6] Fix selecting the same room multiple times
[fb3391d] Move room details presentation responsibility to the RoomFlowCoordinator. Fixed invitation flows.
[fa2a68d] Rename RoomTimelineFlowCoordinator -> RoomFlowCoordinator
[0c9c06b] Start moving things away from the RoomScreenCoordinator and into the RoomTimelineFlowCoordinator
[86cbbdc] Introduce a RoomTimelineFlowCoordinator to deal with timeline related operations
[9b2381b] Introduce the FlowCoordinatorProtocol
    @stefanceriu
    stefanceriu committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9be50cb View commit details
    Browse the repository at this point in the history

  2. Prevent race conditions when adding timeline listeners between the ti… 

    …meline provider and other screens
    @stefanceriu
    stefanceriu committed May 26, 2023
    Configuration menu
    Copy the full SHA
    4a123ca View commit details
    Browse the repository at this point in the history