Merge pull request #13 from blacksonic/master

feat(error): add constructor data attribute to property instead of extending itself

README.md

@@ -18,3 +18,4 @@ Usage
     }).then(function(response) {
       console.log(response);
     });
+

requestError.js

@@ -1,17 +1,14 @@
 'use strict';
 
-var _ = require('lodash');
-
 var SuiteRequestError = function(message, code, data) {
   this.message = message;
   this.name = 'SuiteRequestError';
   this.code = code;
-  this.data = {
-    replyText: message
-  };
-  this.stack = new Error().stack;
-
-  _.extend(this, data);
+  this.data = data || {};
+  if (!this.data.replyText) {
+    this.data.replyText = message;
+  }
+  this.stack = new Error(message).stack;
 };
 
 SuiteRequestError.prototype = Object.create(Error.prototype);

requestError.spec.js

@@ -0,0 +1,25 @@
+'use strict';
+
+var SuiteRequestError = require('./requestError');
+
+describe('SuiteRequestError', function() {
+  it('should extend base Error class', function() {
+    var error = new SuiteRequestError();
+
+    expect(error).to.be.an.instanceOf(Error);
+  });
+
+  it('should store constructor parameters', function() {
+    var error = new SuiteRequestError('Invalid request', 400, { detailedMessage: 'Line too long' });
+
+    expect(error.message).to.eql('Invalid request');
+    expect(error.code).to.eql(400);
+    expect(error.data).to.eql({ detailedMessage: 'Line too long', replyText: 'Invalid request' });
+  });
+
+  it('should always contain replyText in data', function() {
+    var error = new SuiteRequestError('Unauthorized');
+
+    expect(error.data.replyText).to.eql('Unauthorized');
+  });
+});