enable embroider tests in ci #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgraded e-a-i to v2.10.0 upgraded @embroider/test-setup to v4 in order to use current stable version of embroider ob v3
@void-mAlex as addon does not ship any .hbs files, this is technically not needed? Does not hurt for sure, just not needed |
SergeAstapov
approved these changes
Nov 13, 2024
it came up as an error during embroider build due to some of the other addons present; believe it was ember test helpers. so technically I think it might be needed for the wrong reasons. hope that answer is sufficient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved ember-cli-htmlbars to dependencies to bring it in line with new addon output
https://github.com/ember-cli/ember-addon-output/blob/master/package.json#L33
upgraded e-a-i to v2.10.0 which should unlock all the latest features and js syntax
upgraded @embroider/test-setup to v4 in order to use current stable version of embroider of v3